Skip to content

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 22, 2025

Hi all,

This pull request contains a backport of commit fe29cad5 from the openjdk/jdk repository.

The commit being backported was authored by Brent Christian on 6 May 2025 and was reviewed by Kim Barrett and Jaikiran Pai.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8298783 needs maintainer approval

Issue

  • JDK-8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3869/head:pull/3869
$ git checkout pull/3869

Update a local copy of the PR:
$ git checkout pull/3869
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3869

View PR using the GUI difftool:
$ git pr show -t 3869

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3869.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fe29cad5e0b10cd088fc39967599f5a8dcaa445c 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 22, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant