Skip to content

Conversation

satyenme
Copy link

@satyenme satyenme commented Aug 27, 2025

Backporting JDK-8340015: Open source several AWT focus tests - series 7. Adds three window focus event tests. Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is almost clean - had to manually address trivial conflicts with ProblemList.txt. Backporting for parity with Oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340015 needs maintainer approval

Issue

  • JDK-8340015: Open source several AWT focus tests - series 7 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3878/head:pull/3878
$ git checkout pull/3878

Update a local copy of the PR:
$ git checkout pull/3878
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3878/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3878

View PR using the GUI difftool:
$ git pr show -t 3878

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3878.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 147e30070d8adbe65453a3a9316b9324890ea25f 8340015: Open source several AWT focus tests - series 7 Aug 27, 2025
@openjdk
Copy link

openjdk bot commented Aug 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 27, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 27, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

satyenme commented Aug 28, 2025

/approval request for backport of JDK-8340015: Open source several AWT focus tests - series 7

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2 and new manual tests. Patch almost clean (edited ProblemList.txt). Although change has only been present in tip since April, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

@satyenme
8340015: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants