8369506: Bytecode rewriting causes Java heap corruption on AArch64

[TheRealMDoerr]

Clean backport of JDK-8369506 from jdk21u-dev. membar(MacroAssembler::LoadLoad) is already in fast_storefield and fast_accessfield like in higher releases.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8369506 needs maintainer approval

Issue

• JDK-8369506: Bytecode rewriting causes Java heap corruption on AArch64 (Bug - P2 - Approved)

Reviewers

• Andrew Haley (@theRealAph - Reviewer)
• Justin King (@jcking - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4145/head:pull/4145
$ git checkout pull/4145

Update a local copy of the PR:
$ git checkout pull/4145
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4145

View PR using the GUI difftool:
$ git pr show -t 4145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4145.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369506: Bytecode rewriting causes Java heap corruption on AArch64

Reviewed-by: aph, jcking

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 98532ee: 8294591: Fix cast-function-type warning in TemplateTable
• dbfdc50: 8353832: Opensource FontClass, Selection and Icon tests
• 0da7c43: 8354095: Open some JTable bugs 5

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (85accc27)

[TheRealMDoerr]

Thanks for the reviews!

[TheRealMDoerr]

/approval request JDK17u is also affected. The fix is very new, but adding memory barriers doesn't break anything and the corresponding fix for PPC64 has also been backported. The fix can potentially prevent some extremely rare crashes or failures. Backport from jdk21u-dev is clean, has been reviewed and all our tests have passed.

[openjdk]

@TheRealMDoerr
8369506: The approval request has been created successfully.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 9f89682.
Since your change was applied there have been 3 commits pushed to the master branch:

• 98532ee: 8294591: Fix cast-function-type warning in TemplateTable
• dbfdc50: 8353832: Opensource FontClass, Selection and Icon tests
• 0da7c43: 8354095: Open some JTable bugs 5

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 9f89682.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.