Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Nov 1, 2025

Backporting JDK-8352966: Opensource Several Font related tests - Batch 2. As issue title suggests, opensources five Font related tests. Ran GHA Sanity Checks and new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352966 needs maintainer approval

Issue

  • JDK-8352966: Opensource Several Font related tests - Batch 2 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4147/head:pull/4147
$ git checkout pull/4147

Update a local copy of the PR:
$ git checkout pull/4147
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4147

View PR using the GUI difftool:
$ git pr show -t 4147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4147.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352966: Opensource Several Font related tests - Batch 2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9f89682: 8369506: Bytecode rewriting causes Java heap corruption on AArch64
  • 98532ee: 8294591: Fix cast-function-type warning in TemplateTable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport db08726884d90f9139db5d30ee4d36d88c288a06 8352966: Opensource Several Font related tests - Batch 2 Nov 1, 2025
@openjdk
Copy link

openjdk bot commented Nov 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 1, 2025
@openjdk
Copy link

openjdk bot commented Nov 1, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2025

Webrevs

@satyenme
Copy link
Author

satyenme commented Nov 3, 2025

/approval request for backport of JDK-8352966: Opensource Several Font related tests - Batch 2

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Although change has only been present in tip since April, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link

openjdk bot commented Nov 3, 2025

@satyenme
8352966: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 3, 2025
@satyenme
Copy link
Author

satyenme commented Nov 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

Going to push as commit 7d6e99c.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2025
@openjdk openjdk bot closed this Nov 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@satyenme Pushed as commit 7d6e99c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant