Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 1, 2025

Hi all,

This pull request contains a backport of commit d09b0284 from the openjdk/jdk repository.

The commit being backported was authored by Emmanuel Bourg on 29 Jul 2021 and was reviewed by Thomas Schatzl, Chris Hegarty, Iris Clark, Prasanta Sadhukhan and Chris Plummer.

I want to backport this since this will make later backport(JDK-8370732) cleanly

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8271396 needs maintainer approval

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4148/head:pull/4148
$ git checkout pull/4148

Update a local copy of the PR:
$ git checkout pull/4148
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4148

View PR using the GUI difftool:
$ git pr show -t 4148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4148.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d09b028407ff9d0e8c2dfd9cc5d0dca19c4497e3 8271396: Spelling errors Nov 1, 2025
@openjdk
Copy link

openjdk bot commented Nov 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 1, 2025
@openjdk
Copy link

openjdk bot commented Nov 1, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant