Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE #4

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,13 @@ public double getProcessCpuLoad() {
}

private boolean isCpuSetSameAsHostCpuSet() {
if (containerMetrics != null && containerMetrics.getCpuSetCpus() != null) {
return containerMetrics.getCpuSetCpus().length == getHostOnlineCpuCount0();
if (containerMetrics != null) {
// The return value may change (including from non-null to null) and
// the call may involve I/O, so keep the result in a local variable.
int[] cpuSetCpus = containerMetrics.getCpuSetCpus();
if (cpuSetCpus != null) {
return cpuSetCpus.length == getHostOnlineCpuCount0();
}
}
return false;
}
Expand Down