-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" #462
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
❗ This change is not yet ready to be integrated. |
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@yaqsun Only the pull request author can set the pull request state to "open" |
/open |
@zzambers This pull request is now open |
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Backport fixes test failure on some systems (RHEL-8):
sun/security/pkcs11/KeyStore/SecretKeysBasic.sh
Changeset to
P11Key.java
, with path adjusted, applied cleanly. No change toProblemList.txt
, as test was not problem listed on jdk8u.Testing:
GH tier1: OK (hotspot failure is unrelated)
jdk_security: OK (no regressions to master: current master, with backport)
(also manually tested on RHEL-8 - fixed issue)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/462/head:pull/462
$ git checkout pull/462
Update a local copy of the PR:
$ git checkout pull/462
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/462/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 462
View PR using the GUI difftool:
$ git pr show -t 462
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/462.diff
Using Webrev
Link to Webrev Comment