Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Feb 28, 2024

Backport fixes test failure on some systems (RHEL-8):
sun/security/pkcs11/KeyStore/SecretKeysBasic.sh

Changeset to P11Key.java, with path adjusted, applied cleanly. No change to ProblemList.txt, as test was not problem listed on jdk8u.

Testing:
GH tier1: OK (hotspot failure is unrelated)
jdk_security: OK (no regressions to master: current master, with backport)
(also manually tested on RHEL-8 - fixed issue)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8209398 needs maintainer approval

Issue

  • JDK-8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/462/head:pull/462
$ git checkout pull/462

Update a local copy of the PR:
$ git checkout pull/462
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 462

View PR using the GUI difftool:
$ git pr show -t 462

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/462.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 985c7a10ae4b1786c21b9a0de21f8c51a6cbc25d 8209398: sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE" Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 9, 2024
@yaqsun
Copy link
Contributor

yaqsun commented Dec 24, 2024

/open

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

@yaqsun Only the pull request author can set the pull request state to "open"

@zzambers
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Jan 28, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

@zzambers This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants