Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. #464

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Mar 4, 2024

This backport has modified the following aspects:

  • there are 53 cases that do not exist:
    jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
    jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
    jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
    jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
    jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
    jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
    jdk/test/java/awt/Frame/8158918/SetExtendedState.java
    jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
    jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
    jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
    jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
    jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
    jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
    jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
    jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
    jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
    jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
    jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
    jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
    jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
    jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
    jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
    jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
    jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
    jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
    jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
    jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
    jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
    jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
    jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
    jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
    jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
    jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
    jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JList/8161483/Bug8161483.java
    jdk/test/javax/swing/JMenu/8067346/bug8067346.java
    jdk/test/javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java
    jdk/test/javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java
    jdk/test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java
    jdk/test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.java
    jdk/test/javax/swing/JOptionPane/8081019/bug8081019.java
    jdk/test/javax/swing/JTable/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JTableHeader/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java
    jdk/test/javax/swing/JTree/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/plaf/basic/6866751/bug6866751.java
    jdk/test/javax/swing/plaf/windows/6921687/bug6921687.java
    jdk/test/javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java
    jdk/test/javax/swing/text/GlyphPainter2/6427244/bug6427244.java
    jdk/test/javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java
    jdk/test/javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java
    jdk/test/sun/awt/image/OffScreenImageSource/ImageConsumerUnregisterTest.java
    jdk/test/sun/java2d/xrender/HugeGradientTest.java
  • context conflicts are handled
    jdk/test/javax/swing/system/6799345/TestShutdown.java
    jdk/test/javax/swing/Security/6938813/bug6938813.java
    jdk/test/javax/swing/JComboBox/6567433/UpdateUIRecursionTest.java
    jdk/test/javax/swing/JTextArea/6940863/bug6940863.java
    jdk/test/javax/swing/JPopupMenu/7154841/bug7154841.java
    jdk/test/javax/swing/JInternalFrame/Test6325652.java
    jdk/test/javax/swing/JFrame/8016356/bug8016356.java
    jdk/test/javax/swing/JFileChooser/6817933/Test6817933.java
    jdk/test/javax/swing/JFileChooser/6713352/bug6713352.java
    jdk/test/javax/swing/JComponent/8043610/bug8043610.java
    jdk/test/java/awt/print/PrinterJob/PrintCrashTest.java
    jdk/test/java/awt/print/PrinterJob/Margins.java
    jdk/test/java/awt/image/multiresolution/MultiResolutionToolkitImageTest.java
    jdk/test/TEST.ROOT
    jdk/test/com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java
    jdk/test/com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java
    jdk/test/java/awt/Desktop/DesktopGtkLoadTest/DesktopGtkLoadTest.java
    jdk/test/java/awt/Dialog/CloseDialog/CloseDialogTest.java
    jdk/test/java/awt/EmbeddedFrame/DisplayChangedTest/DisplayChangedTest.java
    jdk/test/java/awt/EmbeddedFrame/EmbeddedFrameGrabTest/EmbeddedFrameGrabTest.java
    jdk/test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html
    jdk/test/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java
    jdk/test/java/awt/Frame/NormalToIconified/NormalToIconifiedTest.java
    jdk/test/java/awt/Frame/SetMaximizedBounds/SetMaximizedBounds.java
    jdk/test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java
    jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
    jdk/test/java/awt/font/TextLayout/TestSinhalaChar.java
    jdk/test/java/awt/im/8041990/bug8041990.java
    jdk/test/java/awt/image/MultiResolutionImageTest.java
    jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java
  • context is adapted where needed

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8186259 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8185500 needs maintainer approval

Issues

  • JDK-8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. (Bug - P4 - Approved)
  • JDK-8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java (Bug - P1 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464
$ git checkout pull/464

Update a local copy of the PR:
$ git checkout pull/464
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 464

View PR using the GUI difftool:
$ git pr show -t 464

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/464.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2024

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 34afeced211cd7115e2529b043c1e57dfa1291fe 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 4, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2024

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@yaqsun This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests.
8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java

Add new keyword 'printer'. Some minor test fixes to show headless exception. Add some @requires windows.

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 8c4a65b: 8351098: Bump update version of OpenJDK: 8u462
  • 6a7d893: 8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links
  • 8f8531c: 8285756: clean up use of bad arguments for @clean in langtools tests
  • 24cade6: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
  • 898e131: 8261020: Wrong format parameter in create_emergency_chunk_path
  • 0b5a2e7: 8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1
  • 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
  • 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
  • 5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
  • f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
  • ... and 20 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d731386bf4f6819d5e5f69376e520df3a6262...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mrserb
Copy link
Member

mrserb commented Apr 1, 2024

the two cases no longer exist in the high version jdk, so backport is not performed
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

The test is still there in the jdk8u-dev:

@yaqsun
Copy link
Contributor Author

yaqsun commented Apr 1, 2024

the two cases no longer exist in the high version jdk, so backport is not performed
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java
jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

The test is still there in the jdk8u-dev:

The above two cases have been backport.

@yaqsun
Copy link
Contributor Author

yaqsun commented Apr 19, 2024

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca always fail in test results.

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@yaqsun
Copy link
Contributor Author

yaqsun commented Jul 4, 2024

/approval 8186259 request IOExceptionIfEncodedURLTest.sh and IOExceptionIfEncodedURLTest.java have similar names, fixed according to JDK-8186259.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@yaqsun
8186259: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 4, 2024
@yaqsun
Copy link
Contributor Author

yaqsun commented Jul 4, 2024

/approval 8185500 request add '@key headful' and add '@requires (os.family == "windows")' somewhere.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@yaqsun
8185500: The approval request has been created successfully.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Aug 12, 2024

keep open

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Sep 10, 2024

@gnu-andrew please take a look

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Oct 16, 2024

keep open

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2024

@yaqsun This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 12, 2024
@yaqsun
Copy link
Contributor Author

yaqsun commented Dec 12, 2024

/open

@openjdk openjdk bot reopened this Dec 12, 2024
@openjdk
Copy link

openjdk bot commented Dec 12, 2024

@yaqsun This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Jan 23, 2025

keep open

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2025

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member

mrserb commented Feb 25, 2025

keep open

@jerboaa
Copy link
Contributor

jerboaa commented Feb 25, 2025

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@jerboaa
8185500: The approval request has been approved.
8186259: The approval request has been approved.

@openjdk openjdk bot removed the approval label Feb 25, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants