Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory #551

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Jul 24, 2024

TestNoEagerReclaimOfHumongousRegions.java is placed (as the only test) in gc_implementation/g1 directory instead of gc/g1, where similar tests are placed. As a result test is not part of any test group and is currently not executed as part of tier1.

This seems like mistake in JDK-8139424 backport (orig, 8). Hotspot code uses dir named gc_implementation instead of gc on 8, but this is not the case for tests.

This change moves TestNoEagerReclaimOfHumongousRegions.java hotspot test from gc_implementation/g1 -> gc/g1.

Testing:
tier1: OK (After this change, test newly executes as part of tier1 and passes on all systems. Failures of other tests are unrelated.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337110 needs maintainer approval

Issue

  • JDK-8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/551/head:pull/551
$ git checkout pull/551

Update a local copy of the PR:
$ git checkout pull/551
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 551

View PR using the GUI difftool:
$ git pr show -t 551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/551.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 24, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • edbdf05: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • fb0a658: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e7: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
  • d4adbe3: 8152207: Perform array bound checks while getting a length of bytecode instructions
  • 047b08a: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/765bd89b6c3dd12f9248d8626884103f58cbaa5a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request Fixes location of TestNoEagerReclaimOfHumongousRegions.java, affects test only, GHA testing OK

@openjdk
Copy link

openjdk bot commented Jul 29, 2024

@zzambers
8337110: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 29, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 20, 2024
@zzambers
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

Going to push as commit 7d36fed.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 4942516: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad: 8318951: Additional negative value check in JPEG decoding
  • aa44346: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
  • fc33f51: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 8867d01: 8193682: Infinite loop in ZipOutputStream.close()
  • 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
  • 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e8: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • 855480b: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
  • ... and 29 more: https://git.openjdk.org/jdk8u-dev/compare/765bd89b6c3dd12f9248d8626884103f58cbaa5a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2024
@openjdk openjdk bot closed this Aug 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@zzambers Pushed as commit 7d36fed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants