Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the
giflib.md
file in 11u and later to theTHIRD_PARTY_README
file in 8u (now only one copy following JDK-8338144)8u is also missing JDK-8225487 which I've included as part of this patch. This updates the license to credit
openbsd-reallocarray.c
and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing.The
giflib.md
changes include some odd changes, replacing the giflib VCS URL with justtree/README
. I've raised 8339271 to correct this.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/571/head:pull/571
$ git checkout pull/571
Update a local copy of the PR:
$ git checkout pull/571
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/571/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 571
View PR using the GUI difftool:
$ git pr show -t 571
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/571.diff
Webrev
Link to Webrev Comment