Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benty-amzn
Copy link
Contributor

@benty-amzn benty-amzn commented Sep 10, 2024

This change replaces 3 instances of ThreadLocalStorage::thread with Thread::current_or_null to ensure that ThreadLocalStorage::is_initialized is checked before attempting to get the current thread.

Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8339882 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/576/head:pull/576
$ git checkout pull/576

Update a local copy of the PR:
$ git checkout pull/576
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 576

View PR using the GUI difftool:
$ git pr show -t 576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/576.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2024

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 10, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 11, 2024

Webrevs

@benty-amzn benty-amzn changed the title JDK-8183925: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 JDK-8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 Sep 11, 2024
@openjdk openjdk bot changed the title JDK-8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 Sep 11, 2024
@openjdk
Copy link

openjdk bot commented Sep 11, 2024

⚠️ @benty-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@benty-amzn
Copy link
Contributor Author

Checked the jtreg failures in github actions and I believe they're all unrelated to this change. I also see identical failures on at least one other open PR.

@benty-amzn
Copy link
Contributor Author

/approval request Change 3 instances of ThreadLocalStorage::thread with Thread::current_or_null to retroactively make JDK-8183925 cleaner and ensure that ThreadLocalStorage::is_initialized is checked before attempting to get the current thread.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@benty-amzn
8339882: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants