Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340815: Add SECURITY.md file #584

Closed

Conversation

gdams
Copy link
Member

@gdams gdams commented Sep 27, 2024

Hi all,

This pull request contains a backport of commit 0474f020 from the openjdk/jdk repository.

The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8340815 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8340815: Add SECURITY.md file (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/584/head:pull/584
$ git checkout pull/584

Update a local copy of the PR:
$ git checkout pull/584
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 584

View PR using the GUI difftool:
$ git pr show -t 584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/584.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2024

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 27, 2024

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8340815: Add SECURITY.md file

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 13e86fb: Merge
  • 39221f8: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • f2d72b7: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 0474f020bf276c761f46bc8ba0873ed90a8fd19b 8340815: Add SECURITY.md file Sep 27, 2024
@openjdk
Copy link

openjdk bot commented Sep 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 27, 2024

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2024
@gdams
Copy link
Member Author

gdams commented Sep 27, 2024

/approval request applies cleanly - docs change only so low risk

@openjdk
Copy link

openjdk bot commented Sep 27, 2024

@gdams
8340815: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 27, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2024

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport confirmed clean.

I'm fine with adding this to 8u. I saw the change coming through the other update releases and considered backporting it myself. Thanks for doing so.

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@gnu-andrew
8340815: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 2, 2024
@gdams
Copy link
Member Author

gdams commented Oct 2, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@gdams
Your change (at version 1520c75) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

Going to push as commit b4264bc.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 13e86fb: Merge
  • 39221f8: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • f2d72b7: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 2, 2024
@openjdk openjdk bot closed this Oct 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@phohensee @gdams Pushed as commit b4264bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants