Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338402: GHA: some of bundles may not get removed #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 1, 2024

Only affects GHA. Not a clean backport because gha workflows have been rewritten in newer jdks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8338402 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338402: GHA: some of bundles may not get removed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/586/head:pull/586
$ git checkout pull/586

Update a local copy of the PR:
$ git checkout pull/586
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/586/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 586

View PR using the GUI difftool:
$ git pr show -t 586

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/586.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea 8338402: GHA: some of bundles may not get removed Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant