Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 #594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kurashige23
Copy link
Contributor

@kurashige23 kurashige23 commented Oct 11, 2024

The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic,

sun/security/pkcs11/ec/TestECDH.java
sun/security/pkcs11/ec/TestECDSA.java
sun/security/pkcs11/ec/TestECGenSpec.java

To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic.

Similar fix was made in JDK-8253637 for jdk16 and later, and JDK-8328889 for jdk11.

JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because:

JDK-8253637
About jdk11
・The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11.
・Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java.
・The fix for PKCS11Test.java has already been made in JDK-8313206.
About jdk8
・For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied.
・All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637.

JDK-8313206
In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java.
Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java).

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341946 needs maintainer approval

Issue

  • JDK-8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/594/head:pull/594
$ git checkout pull/594

Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 594

View PR using the GUI difftool:
$ git pr show -t 594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/594.diff

Using Webrev

Link to Webrev Comment

@kurashige23 kurashige23 changed the title JDK-8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 Oct 11, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2024

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2024

Webrevs

@kurashige23
Copy link
Contributor Author

Could anyone review this backport please?

@openjdk
Copy link

openjdk bot commented Oct 28, 2024

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@kurashige23
Copy link
Contributor Author

kurashige23 commented Oct 29, 2024

/approval request Fix the test failure in TestECDH.java, TestECDSA.java and TestECGenSpec.java on RHEL9. Risk is low, test-only fix. pkcs11 tests on RHEL9 and GHA tests pass.

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@kurashige23
8341946: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 29, 2024
@kurashige23
Copy link
Contributor Author

@phohensee

If you have time, I would like you to confirm my fix request.
Thanks.

@phohensee
Copy link
Member

@gnu-andrew, would you please take a look?

@kurashige23
Copy link
Contributor Author

@gnu-andrew
I'm sorry, but if you have time, I would appreciate it if you could check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants