-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 #594
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Could anyone review this backport please? |
|
/approval request Fix the test failure in TestECDH.java, TestECDSA.java and TestECGenSpec.java on RHEL9. Risk is low, test-only fix. pkcs11 tests on RHEL9 and GHA tests pass. |
@kurashige23 |
If you have time, I would like you to confirm my fix request. |
@gnu-andrew, would you please take a look? |
@gnu-andrew |
The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic,
sun/security/pkcs11/ec/TestECDH.java
sun/security/pkcs11/ec/TestECDSA.java
sun/security/pkcs11/ec/TestECGenSpec.java
To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic.
Similar fix was made in JDK-8253637 for jdk16 and later, and JDK-8328889 for jdk11.
JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because:
JDK-8253637
About jdk11
・The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11.
・Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java.
・The fix for PKCS11Test.java has already been made in JDK-8313206.
About jdk8
・For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied.
・All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637.
JDK-8313206
In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java.
Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java).
Thanks
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/594/head:pull/594
$ git checkout pull/594
Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/594/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 594
View PR using the GUI difftool:
$ git pr show -t 594
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/594.diff
Using Webrev
Link to Webrev Comment