8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1

[alexeybakhtin]

…stTest.java fails with jtreg5.1

Tests fixed to be compatible with jtreg 5.1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8346140 needs maintainer approval

Issue

• JDK-8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 (Bug - P5 - Approved)

Reviewers

• SendaoYan (@sendaoYan - no project role)
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/612/head:pull/612
$ git checkout pull/612

Update a local copy of the PR:
$ git checkout pull/612
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 612

View PR using the GUI difftool:
$ git pr show -t 612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/612.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1

Reviewed-by: syan, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
• 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
• 5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
• f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
• fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
• 88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
• 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• 8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
• bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
• f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (04eb44b2)

[sendaoYan]

Tests run passed with jtreg5.1

[bridgekeeper]

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Thanks for catching this. I'll take a look.

[bridgekeeper]

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[alexeybakhtin]

Please review to fix tests running under jtreg5.1

[alexeybakhtin]

MACOS build fails to download crs agent.
Win32 build fails on AWS timeout
CI issues are not related to the MR changes

[jerboaa]

LGTM

[jerboaa]

I've changed the JBS title to include 8u. Please update the PR title accordingly.

[openjdk]

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[alexeybakhtin]

/integrate

[openjdk]

Going to push as commit 0b5a2e7.
Since your change was applied there have been 17 commits pushed to the master branch:

• 8eccf89: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS
• 85fb26b: 8244966: Add .vscode to .hgignore and .gitignore
• 5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
• f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
• fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
• 88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
• 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• 8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
• bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
• f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
• ... and 7 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeybakhtin Pushed as commit 0b5a2e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.