Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names #629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Feb 25, 2025

I backport this for parity with Oracle 8u351
Almost clean backport except for DNSName.java:
small manual merge in the constructor caused by the absence of "JDK-8215281: Use String.isEmpty() when applicable in java.base"

All sun/security/x509 and sun/security/tools/keytool JTREG tests passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8186143 needs maintainer approval

Issue

  • JDK-8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/629/head:pull/629
$ git checkout pull/629

Update a local copy of the PR:
$ git checkout pull/629
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/629/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 629

View PR using the GUI difftool:
$ git pr show -t 629

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/629.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 0c9f8e472f1d452e97b3cbd50b9e5d700fffcd15 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 25, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2025

Webrevs

@alexeybakhtin
Copy link
Contributor Author

Please review.
CI failures in CAInterop test are not related to the proposed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant