Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339803: Acknowledge case insensitive unambiguous keywords in tzdata files #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimitryc
Copy link
Contributor

@dimitryc dimitryc commented Mar 3, 2025

Improves parsing of keywords in tzdata rules

Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339803 needs maintainer approval

Issue

  • JDK-8339803: Acknowledge case insensitive unambiguous keywords in tzdata files (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/632/head:pull/632
$ git checkout pull/632

Update a local copy of the PR:
$ git checkout pull/632
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 632

View PR using the GUI difftool:
$ git pr show -t 632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/632.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2025

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2155f8d22a5e34d9b9386485b2a6a1c2bdf8b52c 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files Mar 3, 2025
@openjdk
Copy link

openjdk bot commented Mar 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 3, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant