-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb #634
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no trailing slash, I think.
Co-authored-by: Severin Gehwolf <jerboaa@gmail.com>
/approval request. Fix for a typo to simplify updating the TimeZone test during the tzdata integration process. |
The TZDATA path has been updated to work with jdk8u-dev layout.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/634/head:pull/634
$ git checkout pull/634
Update a local copy of the PR:
$ git checkout pull/634
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/634/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 634
View PR using the GUI difftool:
$ git pr show -t 634
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/634.diff
Using Webrev
Link to Webrev Comment