Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb #634

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 7, 2025

The TZDATA path has been updated to work with jdk8u-dev layout.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8351439 needs maintainer approval

Issue

  • JDK-8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/634/head:pull/634
$ git checkout pull/634

Update a local copy of the PR:
$ git checkout pull/634
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 634

View PR using the GUI difftool:
$ git pr show -t 634

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/634.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@mrserb mrserb marked this pull request as ready for review March 7, 2025 20:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no trailing slash, I think.

Co-authored-by: Severin Gehwolf <jerboaa@gmail.com>
@mrserb
Copy link
Member Author

mrserb commented Mar 11, 2025

/approval request. Fix for a typo to simplify updating the TimeZone test during the tzdata integration process.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@mrserb
8351439: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants