Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309841: Jarsigner should print a warning if an entry is removed #635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkia
Copy link

@wkia wkia commented Mar 10, 2025

This is backport of "8309841: Jarsigner should print a warning if an entry is removed"

Original patch does not apply cleanly to jdk8:

  • some minor conflicts in JDK code
  • files moved to appropriate locations
  • added the check in jdk/src/share/classes/sun/security/tools/jarsigner/Main.java at line 1196

in tests:

  • ed25519 algorithm was replaced with RSA in RemovedFiles.java
  • JarEntry copyEntry() procedure was manually added to JarUtils.java to make JarUtilsTest working.
  • the tests were adapted to Java 8, including replaced Path.of, Files.writeString, package names, and arrays processing as well.

We need this fix in jdk8, as all versions have this issue with jarsigner.

New tests successfully ran locally on Linux, x86_64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8334261 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8309841 needs maintainer approval

Issues

  • JDK-8309841: Jarsigner should print a warning if an entry is removed (Enhancement - P3)
  • JDK-8334261: Jarsigner should print a warning if an entry is removed (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/635/head:pull/635
$ git checkout pull/635

Update a local copy of the PR:
$ git checkout pull/635
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/635/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 635

View PR using the GUI difftool:
$ git pr show -t 635

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/635.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f 8309841: Jarsigner should print a warning if an entry is removed Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 10, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant