8309841: Jarsigner should print a warning if an entry is removed #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
Original patch does not apply cleanly to jdk8:
jdk/src/share/classes/sun/security/tools/jarsigner/Main.java
at line 1196in tests:
ed25519
algorithm was replaced withRSA
inRemovedFiles.java
JarEntry copyEntry()
procedure was manually added toJarUtils.java
to makeJarUtilsTest
working.Path.of
,Files.writeString
, package names, and arrays processing as well.We need this fix in jdk8, as all versions have this issue with jarsigner.
New tests successfully ran locally on Linux, x86_64.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/635/head:pull/635
$ git checkout pull/635
Update a local copy of the PR:
$ git checkout pull/635
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/635/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 635
View PR using the GUI difftool:
$ git pr show -t 635
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/635.diff
Using Webrev
Link to Webrev Comment