-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java #637
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
This is a clean backport as only path changes. /clean |
@kurashige23 The |
Util.waitForIdle(null); | ||
private static void checkState(Frame frame, int state) { | ||
frame.setExtendedState(state); | ||
robot.waitForIdle(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation.
Hi all,
This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
Original patch applies cleanly to 8u (only path changes).
Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2
Thanks.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/637/head:pull/637
$ git checkout pull/637
Update a local copy of the PR:
$ git checkout pull/637
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/637/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 637
View PR using the GUI difftool:
$ git pr show -t 637
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/637.diff
Using Webrev
Link to Webrev Comment