Skip to content

8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 31, 2025

Hi all,

This pull request contains a clean backport of commit 577ede73 from the openjdk/jdk repository.

The commit being backported was authored by Weijun Wang on 19 Mar 2025 and was reviewed by David Holmes.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352302 needs maintainer approval

Issue

  • JDK-8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/642/head:pull/642
$ git checkout pull/642

Update a local copy of the PR:
$ git checkout pull/642
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/642/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 642

View PR using the GUI difftool:
$ git pr show -t 642

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/642.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 577ede73d8e916bac9050d3bee80d2f18cc833a7 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 31, 2025
@sendaoYan
Copy link
Member Author

/label add clean

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@sendaoYan
The label clean is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Mar 31, 2025

Webrevs

sendaoYan added a commit to sendaoYan/aqa-tests that referenced this pull request Mar 31, 2025
Problemlist sun/security/tools/jarsigner/TimestampCheck.java in jdk8u before fixed PR openjdk/jdk8u-dev#642 been merged.

Fixes: adoptium#6119
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
llxia pushed a commit to adoptium/aqa-tests that referenced this pull request Mar 31, 2025
…#6120)

Problemlist sun/security/tools/jarsigner/TimestampCheck.java in jdk8u before fixed PR openjdk/jdk8u-dev#642 been merged.

Fixes: #6119

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants