Skip to content

Commit

Permalink
8232929: Duplicate symbols when building static libraries
Browse files Browse the repository at this point in the history
Reviewed-by: kcr
  • Loading branch information
Johan Vos committed Oct 24, 2019
1 parent ab6ea3b commit ac71396
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions modules/javafx.graphics/src/main/native-prism-sw/JNIUtil.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ initializeFieldIds(jfieldID* dest, JNIEnv* env, jclass classHandle,
while (fields->name != NULL) {
*dest = (*env)->GetFieldID(env, classHandle, fields->name,
fields->signature);
checkAndClearException(env);
prismsw_checkAndClearException(env);
if (*dest == NULL) {
retVal = JNI_FALSE;
break;
Expand All @@ -69,7 +69,7 @@ initializeStaticFieldIds(jfieldID* dest, JNIEnv* env, jclass classHandle,
while (fields->name != NULL) {
*dest = (*env)->GetStaticFieldID(env, classHandle, fields->name,
fields->signature);
checkAndClearException(env);
prismsw_checkAndClearException(env);
if (*dest == NULL) {
retVal = JNI_FALSE;
break;
Expand Down Expand Up @@ -99,7 +99,7 @@ JNI_ThrowNew(JNIEnv* env, const char* throwable, const char* message) {
}

jboolean
checkAndClearException(JNIEnv *env) {
prismsw_checkAndClearException(JNIEnv *env) {
if (!(*env)->ExceptionCheck(env)) {
return JNI_FALSE;
}
Expand Down
2 changes: 1 addition & 1 deletion modules/javafx.graphics/src/main/native-prism-sw/JNIUtil.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ jboolean initializeStaticFieldIds(jfieldID* dest, JNIEnv* env,

void JNI_ThrowNew(JNIEnv* env, const char* throwable, const char* message);

jboolean checkAndClearException(JNIEnv *env);
jboolean prismsw_checkAndClearException(JNIEnv *env);

#endif
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ initializeObjectFieldIds(JNIEnv *env,
classHandle = (*env)->GetObjectClass(env, objectHandle);
} else if (className != 0) {
classHandle = (*env)->FindClass(env, className);
if (checkAndClearException(env)) return JNI_FALSE;
if (prismsw_checkAndClearException(env)) return JNI_FALSE;
} else {
return JNI_FALSE;
}
Expand Down

0 comments on commit ac71396

Please sign in to comment.