8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView

[jperedadnr]

This PR converts the change's from field from a list of tablePositions into a list of selected indices of rows.

It includes two tests for TableView and one for TreeTableView (the second test wasn't included due to an [issue|https://bugs.openjdk.java.net/browse/JDK-8232825] with key navigation), that pass with this PR and fail without it.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView

Reviewers

• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/710/head:pull/710
$ git checkout pull/710

Update a local copy of the PR:
$ git checkout pull/710
$ git pull https://git.openjdk.java.net/jfx pull/710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 710

View PR using the GUI difftool:
$ git pr show -t 710

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/710.diff

[bridgekeeper]

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full (32fcade9)
• 01: Full - Incremental (ea09a464)
• 00: Full (47abd328)

[jperedadnr]

After #709 was integrated, there were merge conflicts. So I needed to merge from master to fix them.

[aghaisas]

Looks good to me.

[openjdk]

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• ba4c9c6: 8281723: Spinner with split horizontal arrows and a border places right arrow incorrectly
• d960d63: 8281564: Update cmake to 3.22.3
• 18b9e94: 8251480: TableColumnHeader: calc of cell width must respect row styling
• b0f2521: 8283328: Update libxml2 to 2.9.13
• cff84e2: 8283509: Invisible menus can lead to IndexOutOfBoundsException
• a0db473: 8280369: native library cache should be platform/arch specific
• d1fb3d3: 8283517: Update boot JDK to 18
• 424aeba: 8277309: Add support for H.265/HEVC to HTTP Live Streaming
• eb7fa5d: 8270867: Debug build of WebKit 613.1 fails on Linux
• ff75917: 8283183: Skip failing PredefinedMeshManagerTest tests
• ... and 22 more: https://git.openjdk.java.net/jfx/compare/590033f4cb2b5bbe02261a845c554dd08c7866ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jperedadnr]

/integrate

[openjdk]

Going to push as commit c55931f.
Since your change was applied there have been 33 commits pushed to the master branch:

• 64da125: 8284184: Crash in GraphicsContextJava::drawLinesForText on https://us.yahoo.com/
• ba4c9c6: 8281723: Spinner with split horizontal arrows and a border places right arrow incorrectly
• d960d63: 8281564: Update cmake to 3.22.3
• 18b9e94: 8251480: TableColumnHeader: calc of cell width must respect row styling
• b0f2521: 8283328: Update libxml2 to 2.9.13
• cff84e2: 8283509: Invisible menus can lead to IndexOutOfBoundsException
• a0db473: 8280369: native library cache should be platform/arch specific
• d1fb3d3: 8283517: Update boot JDK to 18
• 424aeba: 8277309: Add support for H.265/HEVC to HTTP Live Streaming
• eb7fa5d: 8270867: Debug build of WebKit 613.1 fails on Linux
• ... and 23 more: https://git.openjdk.java.net/jfx/compare/590033f4cb2b5bbe02261a845c554dd08c7866ff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jperedadnr Pushed as commit c55931f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.