-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7765: Bump some Maven plugins #395
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
Webrevs
|
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thanks for the review. |
@RealCLanger |
/sponsor |
Going to push as commit 97403f7. |
@jpbempel @RealCLanger Pushed as commit 97403f7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi @laeubi, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user laeubi for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.
Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use. |
Several maven plugins should be updated to a more current version.
Here's a list with some reasoning:
junit 4.13.1 -> 4.13.2 (minor update)
maven javadoc 3.2.0 -> 3.3.2 (bugfixes, e.g. support javadoc generation with modular JDKs)
mockito 3.7.7 -> 3.12.4 (bugfixes to support newer JDKs, e.g. 17)
tycho 2.5.0 -> 2.7.1 (bugfixes, prepare JDK17 support)
jetty maven plugin 9.4.43.v20210629 -> 9.4.46.v20220331 (minor updates, only used for p2 server during build)
p2-maven-plugin 1.5.0 -> 2.0.0 (prepare JDK 17 support)
build-helper-maven-plugin 3.2.0 -> 3.3.0 (minor update)
To support latest tycho, I added a directive to ignore tycho-consumer-pom.xml to .gitignore. These files seem to be generated by the new tycho version.
I also had to make a small adaption to application/org.openjdk.jmc.feature.pde/feature.xml to overcome eclipse-tycho/tycho#876
In core/tests/pom.xml I removed the entry for maven.javadoc.version since it is inherited from the parent pom.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/395/head:pull/395
$ git checkout pull/395
Update a local copy of the PR:
$ git checkout pull/395
$ git pull https://git.openjdk.java.net/jmc pull/395/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 395
View PR using the GUI difftool:
$ git pr show -t 395
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/395.diff