Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7765: Bump some Maven plugins #395

Closed
wants to merge 2 commits into from

Conversation

RealCLanger
Copy link
Collaborator

@RealCLanger RealCLanger commented Apr 12, 2022

Several maven plugins should be updated to a more current version.

Here's a list with some reasoning:
junit 4.13.1 -> 4.13.2 (minor update)
maven javadoc 3.2.0 -> 3.3.2 (bugfixes, e.g. support javadoc generation with modular JDKs)
mockito 3.7.7 -> 3.12.4 (bugfixes to support newer JDKs, e.g. 17)
tycho 2.5.0 -> 2.7.1 (bugfixes, prepare JDK17 support)
jetty maven plugin 9.4.43.v20210629 -> 9.4.46.v20220331 (minor updates, only used for p2 server during build)
p2-maven-plugin 1.5.0 -> 2.0.0 (prepare JDK 17 support)
build-helper-maven-plugin 3.2.0 -> 3.3.0 (minor update)

To support latest tycho, I added a directive to ignore tycho-consumer-pom.xml to .gitignore. These files seem to be generated by the new tycho version.

I also had to make a small adaption to application/org.openjdk.jmc.feature.pde/feature.xml to overcome eclipse-tycho/tycho#876

In core/tests/pom.xml I removed the entry for maven.javadoc.version since it is inherited from the parent pom.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/395/head:pull/395
$ git checkout pull/395

Update a local copy of the PR:
$ git checkout pull/395
$ git pull https://git.openjdk.java.net/jmc pull/395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 395

View PR using the GUI difftool:
$ git pr show -t 395

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/395.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JMC-7765 7765: Bump some Maven plugins Apr 12, 2022
@openjdk openjdk bot added the rfr label Apr 12, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7765: Bump some Maven plugins

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 12, 2022
@RealCLanger
Copy link
Collaborator Author

Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor label Apr 12, 2022
@openjdk
Copy link

openjdk bot commented Apr 12, 2022

@RealCLanger
Your change (at version 714c37b) is now ready to be sponsored by a Committer.

@jpbempel
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

Going to push as commit 97403f7.

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@jpbempel @RealCLanger Pushed as commit 97403f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the bump-plugins branch April 13, 2022 08:16
@laeubi
Copy link

laeubi commented Apr 22, 2022

Hi @laeubi, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user laeubi for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants