Overload javafx:run goal to work with JavaFX 17

[abhinayagarwal]

This is a hack to make sure that Maven application don't fail with JavaFX 17.

Since there is no way to update the dependency list after its creation in MavenProject, we had to resort for the creation of a new Mojo: JavaFXRunFixMojo which will be called for javafx:run. This new Mojo will then create a new pom.xml which will add classifiers to the JavaFX dependencies and exclude all JavaFX transitive dependencies.

For example, a dependency for javafx-controls on linux, will be available as the following in the new modified pom:

<dependency>
  <groupId>org.openjfx</groupId>
  <artifactId>javafx-controls</artifactId>
  <version>17</version>
  <classifier>linux</classifier>
  <exclusions>
    <exclusion>
      <artifactId>*</artifactId>
      <groupId>org.openjfx</groupId>
    </exclusion>
  </exclusions>
</dependency>

We will then call the existing, JavaFXRunMojo with this new pom.

Since 2 Mojo's cannot have the same name, the name for JavaFXRunMojo has been updated to runx.

This has been tested against the following Applications:

Modular

• ChatApp
• OpenJFX Modular Sample

Non-Modular

• Scene Builder
• OpenJFX Non-Modular Sample

[jperedadnr]

Add a TODO to restore the name, once fix is not longer required?

[jperedadnr]

Test works with fine, but needs runx:

JavaFXRunMojo mojo = (JavaFXRunMojo) lookupMojo("runx", testPom);

[betanzos]

Great work @abhinayagarwal!

However I have found 2 issues that I comment below.

1. Custom settings.xml file definition is ignored

If we need to use a settings.xml file other than the default one via command line (by using the -s param), configuration defined by this are ignored and the goal can ends with error.

For example, I have some settings.xml files which define server entries for my org private artifacts. If I try to use any of this settings files those private artifacts are not downloaded because credentials are not found.

2. JAVA_HOME required from IntelliJ IDEA

When running the goal from IntelliJ IDEA the goal fails if the JAVA_HOME env variable is not defined.

[INFO] --- javafx-maven-plugin:0.0.7-SNAPSHOT:run (default-cli) @ hellofx ---
The JAVA_HOME environment variable is not defined correctly 
This environment variable is needed to run this program 
NB: JAVA_HOME should point to a JDK not a JRE 

IMPORTANT NOTES
None of these problems are present...

1. in the version 0.0.6
2. if we using the goal javafx:runx and JavaFX 16

[abhinayagarwal]

@betanzos I have pushed a fix for the settings file.

For the IntelliJ IDEA issue, I cannot reproduce the issue. If I use the platform Maven in IntelliJ IDEA, everything seems to work fine. However, if I use the bundled Maven, I am hit by https://youtrack.jetbrains.com/issue/IDEA-139236. Once I provide executable permission to mvn, everything works fine.

[johanvos]

works for me

[johanvos]

@betanzos I have pushed a fix for the settings file.

For the IntelliJ IDEA issue, I cannot reproduce the issue. If I use the platform Maven in IntelliJ IDEA, everything seems to work fine. However, if I use the bundled Maven, I am hit by https://youtrack.jetbrains.com/issue/IDEA-139236. Once I provide executable permission to mvn, everything works fine.

In case it turns out to be an issue, we can create a follow-up issue. For now, this PR is good to be merged.

[betanzos]

@betanzos I have pushed a fix for the settings file.

@abhinayagarwal this is fixed!

For the IntelliJ IDEA issue, I cannot reproduce the issue. If I use the platform Maven in IntelliJ IDEA, everything seems to work fine. However, if I use the bundled Maven, I am hit by https://youtrack.jetbrains.com/issue/IDEA-139236. Once I provide executable permission to mvn, everything works fine.

Using both an external and bundled Maven I get the same error. This only happens when I don't have defined the JAVA_HOME env variable. Version 0.0.6 and javafx:dorun goal work fine, so this problem was introduced by the new javafx:run goal.