[REVIEW]: Your: Your Unified Reader

[whedon]

Submitting author: @KshitijAggarwal (Kshitij Aggarwal)
Repository: https://github.com/thepetabyteproject/your
Version: 0.6.0
Editor: @dfm
Reviewer: @pravirkr, @paulray
Archive: 10.5281/zenodo.4269947

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/798844ebd352f563de28bb75515da674"><img src="https://joss.theoj.org/papers/798844ebd352f563de28bb75515da674/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/798844ebd352f563de28bb75515da674/status.svg)](https://joss.theoj.org/papers/798844ebd352f563de28bb75515da674)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@pravirkr & @paulray, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

1. Make sure you're logged in to your GitHub account
2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @pravirkr

Conflict of interest

• I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

• I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• Repository: Is the source code for this software available at the repository url?
• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• Contribution and authorship: Has the submitting author (@KshitijAggarwal) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
• Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• State of the field: Do the authors describe how this software compares to other commonly-used packages?
• Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
• References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @paulray

Conflict of interest

• I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

• I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• Repository: Is the source code for this software available at the repository url?
• License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• Contribution and authorship: Has the submitting author (@KshitijAggarwal) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
• Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• State of the field: Do the authors describe how this software compares to other commonly-used packages?
• Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
• References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @pravirkr, @paulray it looks like you're currently assigned to review this paper 🎉.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

2. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/staa1927 is OK
- 10.1111/j.1745-3933.2010.00882.x is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.5281/zenodo.3509134 is OK
-  10.25080/Majora-92bf1922-00a  is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.1109/mcse.2011.37 is OK
- 10.1071/AS04022 is OK
- 10.1145/2833157.2833162 is OK
- 10.1111/j.1365-2966.2012.20622.x is OK
- 10.1093/mnras/staa1856 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[whedon]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[pravirkr]

The software package your is well-organized with a nice interface. The documentation is very detailed with lots of good examples. This package is going to be very useful for the FRB/radio transients science.

I have opened the following issues within the main repository:

• pip install does not install required dependencies thepetabyteproject/your#46
• MatplotlibDeprecationWarning thepetabyteproject/your#47
• Documentation Issues thepetabyteproject/your#48
• Paper Review thepetabyteproject/your#49

Most of these are very minor issues. Apologies for nitpicking (reviewing for the first time).

[KshitijAggarwal]

@pravirkr, thanks for the issues. We have addressed those from our end, feel free to take a look and close them.

[paulray]

I'm supposed to answer this question: "Does the full list of paper authors seem appropriate and complete?"
I don't know how to judge that, other than from git commits. Is there a statement of the various author contributions somewhere? I didn't see it in the paper.

[KshitijAggarwal]

Hi @paulray, I can answer that here:
@KshitijAggarwal @devanshkv: equal contribution in terms of code, ideas, discussion, structure and documentation
@scottransom: original author of psrfits, which was modified for your
@demorest: original author of pysigproc, which was modified for your
@ReshmaAnnaThomas and @wcfiore: wrote + contributed to filwriter.py
@josephwkania: worked on RFI mitigation functions, your_viewer
@xiggystardust, Duncan Lorimer, Maura McLaughlin, @nategarver-daniels: contributed through discussions and structure
@rwharton: original author of fitswriter, which was then modified for your

[paulray]

Thanks, that is extremely helpful!

[paulray]

Regarding my review, I want to disclose the following potential COIs.

• Scott Ransom and I are longtime collaborators. We are co-Is on several funded guest observer proposals and work closely together on the open source PINT project and many aspects of Fermi and pulsar science.
• Paul Demorest is a collaborator of mine on several projects.
• Maura McLaughlin is a close collaborator on Fermi pulsar searches and some other projects.
• All of the above people as well as Kshitij Aggarwal, Sarah Burke-Spolaor, Dunc Lorimer, Nate Garver-Daniels, and William Fiore are (or were) members of the NANOGrav collaboration that I am a full member of. We all collaborate and co-author many papers together.

I just now realized that the submitting author is a NANOGrav member. I don't think that is a serious conflict since I wasn't even aware of it. According to the statement above, my other potential COIs generally have a largely advisory role in this project or have prior code that was subsumed into this project.

I don't think these potential COIs affect my ability to make an impartial review, so I propose that they be waived.

[dfm]

@paulray: Thanks for bringing these up! I agree that these potential conflicts seem ok to be waived.

@KshitijAggarwal: do you or co-authors don't have any concerns about this? Please feel free to let me know here or offline via email if you'd prefer. Thanks!

[KshitijAggarwal]

@dfm @paulray: We don't have any concerns regarding this.

[paulray]

I enjoyed reviewing the paper and the code and trying it out on same data I had. I found it well explained, easy to install and the documentation was very clear. Nice work!

[KshitijAggarwal]

@pravirkr @dfm, we are submitting an NSF proposal for a project (the petabyte project) which is going to rely on this library. The NSF proposal is due pretty soon. I also noticed that only a few checklist items are left in the review. So I wanted to ask if it would be possible to complete this review in the next day or so? This way we can properly cite it in our proposal, and also upload it to arxiv.
If not, is it okay if we upload the paper to arxiv before the review process is complete?

[dfm]

You're welcome to post the pre-print to ArXiv, but sometimes ArXiv doesn't accept JOSS papers so no guarantees that it will work!

@pravirkr: you definitely shouldn't feel pressured to finish your review faster than planned!

[pravirkr]

@dfm: Thanks. I was waiting for the resolution of the above issues.
@KshitijAggarwal: Thanks for addressing the issues. Looks good now! The only thing left to do IMO is to release the updated version (0.5.9, I guess).

I also recommend acceptance of this work.

[dfm]

@whedon generate pdf

[whedon]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[dfm]

@whedon check references

[whedon]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/staa1927 is OK
- 10.1111/j.1745-3933.2010.00882.x is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.5281/zenodo.3509134 is OK
-  10.25080/Majora-92bf1922-00a  is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.1109/mcse.2011.37 is OK
- 10.1071/AS04022 is OK
- 10.1145/2833157.2833162 is OK
- 10.1111/j.1365-2966.2012.20622.x is OK
- 10.1093/mnras/staa1856 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[dfm]

@pravirkr, @paulray: Thanks for your reviews!!

@KshitijAggarwal: I'm going to go through the paper and do some final checks. Then I'll give you a few instructions to prepare for final review. This will include minting a new release so no need to do that yet!

[KshitijAggarwal]

@pravirkr, @paulray: thanks for the reviews and useful comments!

@dfm: Thanks and that sounds good!

[dfm]

@KshitijAggarwal: I've just submitted a small pull request with some formatting changes. After you take a look at that, here are the steps to run:

1. Comment @whedon generate pdf on this thread and carefully read through the manuscript to make sure that you're happy with it because it can be hard to update later. You should especially double check author names and affiliations.
2. Update the version number on the software and create an archive of that release (using Zenodo or similar) and report the archive DOI and new version number to this thread. NOTE: The title and author list in the archive metadata must exactly match this manuscript (you can generally update the metadata even after the archive has been made).

Let me know if you have any issues or questions!

[whedon]

OK. 0.6.0 is the version.

[dfm]

@KshitijAggarwal: I found a few more remaining formatting issues with the manuscript. Take a look at that PR and then we should be good to go!

[devanshkv]

@dfm merged!

[dfm]

@whedon generate pdf

[whedon]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[dfm]

@whedon check references

[whedon]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/staa1927 is OK
- 10.1111/j.1745-3933.2010.00882.x is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.5281/zenodo.3509134 is OK
-  10.25080/Majora-92bf1922-00a  is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.1071/AS04022 is OK
- 10.1145/2833157.2833162 is OK
- 10.1111/j.1365-2966.2012.20622.x is OK
- 10.1093/mnras/staa1856 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[dfm]

@whedon accept

[whedon]

Attempting dry run of processing paper acceptance...

[whedon]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/staa1927 is OK
- 10.1111/j.1745-3933.2010.00882.x is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.5281/zenodo.3509134 is OK
-  10.25080/Majora-92bf1922-00a  is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.1071/AS04022 is OK
- 10.1145/2833157.2833162 is OK
- 10.1111/j.1365-2966.2012.20622.x is OK
- 10.1093/mnras/staa1856 is OK
- 10.1038/s41586-020-2649-2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[whedon]

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉 openjournals/joss-papers#1907

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1907, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

[dfm]

An editor-in-chief will take a final look at this submission and then we should be good to go.

Thanks again @pravirkr and @paulray for your reviews!!

[devanshkv]

Thanks, @dfm, @pravirkr, and @paulray.

[KshitijAggarwal]

Thanks a lot, @dfm, @pravirkr, and @paulray!!

[josephwkania]

Thanks @dfm, @pravirkr, @paulray! 😊

[kthyng]

@whedon accept deposit=true

[whedon]

Doing it live! Attempting automated processing of paper acceptance...

[whedon]

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

[whedon]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.02750 joss-papers#1912
1. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02750
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[kthyng]

Congrats on your new publication @KshitijAggarwal! Many thanks to editor @dfm and reviewers @pravirkr and @paulray for your time and expertise!! 🎉

[whedon]

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02750/status.svg)](https://doi.org/10.21105/joss.02750)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02750">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02750/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02750/status.svg
   :target: https://doi.org/10.21105/joss.02750

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

[KshitijAggarwal]

Thanks a lot, everyone!!! :) :)