[PRE REVIEW]: Katsu: Integrated polarimetry and polarization simulation

[editorialbot]

Submitting author: @Jashcraf (Jaren Ashcraft)
Repository: https://github.com/Jashcraf/katsu
Branch with paper.md (empty if default branch):
Version: v0.1.0
Editor: @dfm
Reviewers: @benjaminpope, @arendMoerman
Managing EiC: Arfon Smith

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/82536dc5307fe34ddd929c89ed3d2575"><img src="https://joss.theoj.org/papers/82536dc5307fe34ddd929c89ed3d2575/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/82536dc5307fe34ddd929c89ed3d2575/status.svg)](https://joss.theoj.org/papers/82536dc5307fe34ddd929c89ed3d2575)

Author instructions

Thanks for submitting your paper to JOSS @Jashcraf. Currently, there isn't a JOSS editor assigned to your paper.

@Jashcraf if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1184.3 files/s, 220648.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          10            740           1077           1333
CSS                              4            336             52           1319
JavaScript                       6            124            180            776
Jupyter Notebook                13              0           2305            399
HTML                             4            161              0            273
TeX                              1             19              0            208
Markdown                         3             21              0             83
YAML                             3              9              9             61
reStructuredText                 5             31             44             45
DOS Batch                        1              8              1             26
TOML                             1              4              0             24
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            52           1457           3675           4556
-------------------------------------------------------------------------------

Commit count by author:

    66	Jaren Ashcraft
    20	Jashcraf
     9	kenjim21
     7	Work
     3	wcmelby
     2	Rebecca Zhang
     1	becca9808

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1364/OL.2.000148 is OK
- 10.1364/AO.41.002488 is OK
- 10.1117/12.2525377 is OK
- 10.1364/JOSAA.13.001106 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1117/12.2678001 is OK
- 10.21105/joss.01352 is OK
- 10.1364/JOSAA.472364 is OK
- 10.21105/joss.02693 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Polarized Light and Optical Systems
- No DOI given, and none found for title: Polarization aberrations in next-generation giant ...
- No DOI given, and none found for title: The Habitable Exoplanet Observatory (HabEx) Missio...
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
- No DOI given, and none found for title: 
- No DOI given, and none found for title: Gromit: Repository containing code to use the UASA...
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...

❌ MISSING DOIs

- 10.1117/12.3019204 may be a valid DOI for title: The space coronagraph optical bench (SCoOB): 3. Mu...
- 10.1117/12.3019556 may be a valid DOI for title: Half-wave plate characterizations for the Keck NIR...

❌ INVALID DOIs

- https://zenodo.org/badge/latestdoi/128805296 is INVALID because of 'https://doi.org/' prefix

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 614

✅ The paper includes a Statement of need section

[editorialbot]

License info:

🔴 Failed to discover a valid open source license

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

PyPO: a Python package for Physical Optics
Submitting author: @arendMoerman
Handling editor: @danielskatz (Active)
Reviewers: @MikeHughesKent, @brandondube
Similarity score: 0.7596

prysm: A Python optics module
Submitting author: @brandondube
Handling editor: @xuanxu (Active)
Reviewers: @aquilesC
Similarity score: 0.7434

Your: Your Unified Reader
Submitting author: @KshitijAggarwal
Handling editor: @dfm (Active)
Reviewers: @pravirkr, @paulray
Similarity score: 0.7333

ZodiPy: A Python package for zodiacal light simulations
Submitting author: @MetinSa
Handling editor: @dfm (Active)
Reviewers: @dfm
Similarity score: 0.7288

Astronomical échelle spectroscopy data analysis with muler
Submitting author: @gully
Handling editor: @xuanxu (Active)
Reviewers: @bmorris3, @wtgee
Similarity score: 0.7211

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[dfm]

@Jashcraf — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

In the meantime, there's some initial work to do on the repository:

1. Please add a license.
2. You should clean up all the temporary files. Things like .DS_Store, .ipynb_checkpoints, *.egg-info, docs/_build, and __pycache__ shouldn't be checked into a repo. You can use a .gitignore to help with that.

Thanks!

[Jashcraf]

Hi @dfm, thanks for getting us on the waitlist! I'll make the requested changes - can't believe I forgot a license, my apologies!

[dfm]

@editorialbot assign me as editor

@Jashcraf — Thanks for your patience! I'm now available to start editing your submission. I'll start reaching out to reviewers in the coming days, and then, once we have two reviewers, we will start the main review in a new thread. Let me know if you have any questions as we go.

[editorialbot]

Assigned! @dfm is now the editor

[Jashcraf]

@dfm awesome glad to hear it - thank you very much!

[dfm]

👋 @scottprahl, @benjaminpope, @arendMoerman — would any of you be willing to review this submission for The Journal of Open Source Software? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[benjaminpope]

Yes, I'd be happy to.

[arendMoerman]

I'd be happy to review as well!

[dfm]

@editorialbot add @benjaminpope as reviewer

[editorialbot]

@benjaminpope added to the reviewers list!

[dfm]

@editorialbot add @arendMoerman as reviewer

[editorialbot]

@arendMoerman added to the reviewers list!

[dfm]

Thanks @benjaminpope and @arendMoerman!!

I'll get the review started now in a new thread, and I'll have a lot more information for all of you there. Thanks again!!

[dfm]

@editorialbot start review

[editorialbot]

OK, I've started the review over in #7375.