-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: RivGraph: Automatic extraction and analysis of river and delta channel network topology #2952
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @eriknes, @leotrs it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
@kbarnhart After a Zotero update, it started exporting my full library by default instead of just a particular collection. whedon's DOI check is thus of my entire library, not just the references in the paper. I have fixed the .bib file in the RivGraph repo to only contain the relevant refs, but I'm not sure how to ask whedon to re-run the DOI check. |
@whedon check references |
|
@jonschwenk done. for reference here is the list of things whedon can do |
In trying to install the package, I ran into some problems reported here. I will continue my review pending the fix. Update: the mentioned issue is fixed and now I can continue my review. |
👋 @eriknes, please update us on how your review is going. |
👋 @leotrs, please update us on how your review is going. |
@eriknes and @leotrs, we have an automatic reminder two weeks into the review. Feel free to provide an update if you have one. @leotrs making an issue in the main repo and linking it here is perfect. Thank you! If you paste |
I have finished the review checklist and it is my opinion that the software and manuscript meet JOSS standards. Issues in target repository associated to my review: |
@kbarnhart Just curious how things are going here. Haven't seen any movement from @eriknes... |
Hi,
Sorry for the late reply
I have a revision due this weekend and will complete this review over the
weekend if that's ok?
Best,
Erik
…On Thu, Feb 18, 2021 at 1:52 AM Jon Schwenk ***@***.***> wrote:
@kbarnhart <https://github.com/kbarnhart> Just curious how things are
going here. Haven't seen any movement from @eriknes
<https://github.com/eriknes>...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2952 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7R2DE6C345X6I3BBTUGP3S7RQFTANCNFSM4WBGVY7Q>
.
|
@jonschwenk thanks for checking in. The review started Jan 13th, and JOSS is requesting reviewers complete their reviews within 6 weeks. @eriknes if you could complete the review by the middle of next week that would be great. |
Dear Katy,
It seems like the invitation may have expired - can you resend it to me? I
will complete the review tomorrow morning CET time.
I am sorry it has taken some time.
Best regards,
Erik
…On Thu, Feb 18, 2021 at 2:16 PM Katy Barnhart ***@***.***> wrote:
@jonschwenk <https://github.com/jonschwenk> thanks for checking in. The
review started Jan 13th, and JOSS is requesting reviewers complete their
reviews within 6 weeks. @eriknes <https://github.com/eriknes> if you
could complete the review by the middle of next week that would be great.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2952 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7R2DCIVC3Z6KDDYQ6AQ2DS7UHLFANCNFSM4WBGVY7Q>
.
|
OK, the reviewer has been re-invited. @eriknes please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
@eriknes this link should work. Let me know if it doesnt. |
Minor copyedits associated with the JOSS publication. openjournals/joss-reviews/issues/2952
@jonschwenk I've proposed some very minor copyedits at VeinsOfTheEarth/RivGraph/pull/48 Please consider, and if you don't disagree, merge. Once you've done that please double check that the paper compiles and complete the following next steps:
I can then move forward with accepting the submission. |
@whedon generate pdf |
@whedon generate pdf |
@kbarnhart Checklist complete.
|
@whedon set 10.5281/zenodo.4591559 as archive |
OK. 10.5281/zenodo.4591559 is the archive. |
@whedon set v0.4 as version |
OK. v0.4 is the version. |
@whedon accept |
|
|
@jonschwenk I've now recommended that is submission be accepted and published. One of the JOSS EICs will handle the final steps @openjournals/joss-eics. Congratulations to you and @elbeejay on a valuable contribution to research software. Many thanks to reviewers @leotrs and @eriknes for contributing thoughtful and constructive reviews. |
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2137 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2137, then you can now move forward with accepting the submission by compiling again with the flag
|
Awesome. Big thanks to @leotrs, @eriknes for their reviews. Bigger thanks to JOSS and editors like @kbarnhart who provide an awesome platform for scientific developers to announce, share, and get credit for their work. Also thanks whedon! |
@whedon accept deposit=true Looks good to me! |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats @jonschwenk on your article's publication in JOSS! Many thanks to @eriknes and @leotrs for reviewing this, and @kbarnhart for editing. (FYI, the DOI successfully resolves, but it looks like the final PDF is not yet appearing—this should change shortly.) |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jonschwenk (Jon Schwenk)
Repository: https://github.com/jonschwenk/RivGraph
Version: v0.4
Editor: @kbarnhart
Reviewer: @eriknes, @leotrs
Archive: 10.5281/zenodo.4591559
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@eriknes & @leotrs, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kbarnhart know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @eriknes
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @leotrs
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: