-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: SPbLA: The Library of GPGPU-powered Sparse Boolean Linear Algebra Operations #3743
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @abb58, @mlxd it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
PDF failed to compile for issue #3743 with the following error:
|
|
|
@whedon generate pdf from branch joss-paper |
|
👋🏼 @EgorOrachyov @abb58, @mlxd this is the review thread for the paper. All of our communications will happen here from now on. Both reviewers have checklists at the top of this thread with the JOSS requirements 🔝 As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #3743 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use Whedon (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@Nikoleta-v3 ) if you have any questions/concerns 👍🏻 😄 |
@EgorOrachyov please fix the missing DOI: #3743 (comment) :) |
Missing doi fixed! :) |
@whedon generate pdf from branch joss-paper |
|
👋 @mlxd, please update us on how your review is going (this is an automated reminder). |
👋 @abb58, please update us on how your review is going (this is an automated reminder). |
@mlxd Hi, thank you for your issue feedback. I hope, we've fixed it! Check out the latest source code version. |
Thanks @EgorOrachyov ! I'll try to get around to reviewing these in the coming days. |
HI @EgorOrachyov just a quick update. I am having GPU issues at the moment, expect it to be resolved in the coming days and will finish review once done. |
Thank you for the update! @abb58, please let us know how your review is going 😄 |
Apologies for the delays. I have added a new issue for compiling the library at SparseLinearAlgebra/spbla#13 |
Issue added for adding additional examples: SparseLinearAlgebra/spbla#14 |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3448, then you can now move forward with accepting the submission by compiling again with the command |
@EgorOrachyov there is a missing DOI. Could you please take care of this? 😄 |
My apologises for only raising the issue now. I was sure I checked the references 😅 |
@Nikoleta-v3 If I understand you correctly, I have to fix doi |
@editorialbot generate pdf |
@Nikoleta-v3 Seems to be fixed now
|
@editorialbot check references |
|
dear editors please note that I've set the version to be the tagged release
So the Zenodo archive is based on the tagged release |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3449, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@mlxd, @bencardoen – many thanks for your reviews here and to @Nikoleta-v3 for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @EgorOrachyov – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Many thanks to joss community for reviewing and editing this submission. We are very pleased that we have an opportunity to finally publish it 🎉🚀 |
Congrats on the acceptance @EgorOrachyov |
Submitting author: @EgorOrachyov (Egor Orachev)
Repository: https://github.com/JetBrains-Research/spbla
Branch with paper.md (empty if default branch): joss-paper
Version: v1.0.0
Editor: @Nikoleta-v3
Reviewers: @mlxd, @bencardoen
Archive: 10.5281/zenodo.7009938
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@abb58 & @mlxd, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Nikoleta-v3 know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @abb58
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @mlxd
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: