Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: SPbLA: The Library of GPGPU-powered Sparse Boolean Linear Algebra Operations #3743

Closed
20 of 40 tasks
whedon opened this issue Sep 21, 2021 · 115 comments
Closed
20 of 40 tasks
Assignees
Labels
accepted CMake published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Shell

Comments

@whedon
Copy link

whedon commented Sep 21, 2021

Submitting author: @EgorOrachyov (Egor Orachev)
Repository: https://github.com/JetBrains-Research/spbla
Branch with paper.md (empty if default branch): joss-paper
Version: v1.0.0
Editor: @Nikoleta-v3
Reviewers: @mlxd, @bencardoen
Archive: 10.5281/zenodo.7009938

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1da10be51ab03b0f574f2fda4aabc3f9"><img src="https://joss.theoj.org/papers/1da10be51ab03b0f574f2fda4aabc3f9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1da10be51ab03b0f574f2fda4aabc3f9/status.svg)](https://joss.theoj.org/papers/1da10be51ab03b0f574f2fda4aabc3f9)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@abb58 & @mlxd, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Nikoleta-v3 know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Review checklist for @abb58

✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@EgorOrachyov) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @mlxd

✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@EgorOrachyov) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon
Copy link
Author

whedon commented Sep 21, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @abb58, @mlxd it looks like you're currently assigned to review this paper 🎉.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 21, 2021

Wordcount for paper.md is 394

@whedon
Copy link
Author

whedon commented Sep 21, 2021

PDF failed to compile for issue #3743 with the following error:

 /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:155:in `block in check_orcids': Problem with ORCID (0000-0000-0000-0000) for Egor Orachev^[co-first author] (RuntimeError)
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:153:in `each'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:153:in `check_orcids'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:90:in `initialize'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in `new'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in `set_paper'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:58:in `prepare'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:131:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'

@whedon
Copy link
Author

whedon commented Sep 21, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1186/1471-2105-14-149 is OK
- 10.1145/2499370.2462159 is OK
- 10.1145/3210259.3210264 is OK
- 10.1007/978-3-030-54832-2_6 is OK

MISSING DOIs

- 10.1007/978-3-319-46523-4_38 may be a valid DOI for title: Context-Free Path Queries on RDF Graphs

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Sep 21, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.57 s (526.7 files/s, 94282.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                    96           4745           6380          22648
C++                             98           1677           1552           5539
OpenCL                          31            961            215           3345
CUDA                            29            602            605           1850
Python                          20            505            546           1128
Markdown                         8            204              0            708
CMake                            9             85             31            382
Bourne Shell                     6             17             21            109
YAML                             2             14              2            107
TeX                              1              5              0             70
SVG                              2              0              0              2
-------------------------------------------------------------------------------
SUM:                           302           8815           9352          35888
-------------------------------------------------------------------------------


Statistical information for the repository '686d7eec9413c01fa1158df8' was
gathered on 2021/09/21.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Egor19035                       11          7145            913           11.05
EgorOrachev                      3            11           8250           11.33
Maria Karpenko                  15         45080          11508           77.62

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
EgorOrachev               11123       101118.2          2.7               25.60
Maria Karpenko            33597           74.5          2.5               15.90

@Nikoleta-v3
Copy link

@whedon generate pdf from branch joss-paper

@whedon
Copy link
Author

whedon commented Sep 21, 2021

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Sep 21, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Nikoleta-v3
Copy link

👋🏼 @EgorOrachyov @abb58, @mlxd this is the review thread for the paper. All of our communications will happen here from now on.

Both reviewers have checklists at the top of this thread with the JOSS requirements 🔝 As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #3743 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use Whedon (our bot) to set automatic reminders if you know you'll be away for a known period of time.

Please feel free to ping me (@Nikoleta-v3 ) if you have any questions/concerns 👍🏻 😄

@Nikoleta-v3
Copy link

@EgorOrachyov please fix the missing DOI: #3743 (comment) :)

@EgorOrachyov
Copy link

Missing doi fixed! :)

@EgorOrachyov
Copy link

@whedon generate pdf from branch joss-paper

@whedon
Copy link
Author

whedon commented Sep 21, 2021

Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Sep 21, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Oct 5, 2021

👋 @mlxd, please update us on how your review is going (this is an automated reminder).

@whedon
Copy link
Author

whedon commented Oct 5, 2021

👋 @abb58, please update us on how your review is going (this is an automated reminder).

@EgorOrachyov
Copy link

@mlxd Hi, thank you for your issue feedback. I hope, we've fixed it! Check out the latest source code version.

@mlxd
Copy link

mlxd commented Oct 13, 2021

@mlxd Hi, thank you for your issue feedback. I hope, we've fixed it! Check out the latest source code version.

Thanks @EgorOrachyov ! I'll try to get around to reviewing these in the coming days.

@mlxd
Copy link

mlxd commented Oct 26, 2021

HI @EgorOrachyov just a quick update. I am having GPU issues at the moment, expect it to be resolved in the coming days and will finish review once done.

@Nikoleta-v3
Copy link

Thank you for the update! @abb58, please let us know how your review is going 😄

@mlxd
Copy link

mlxd commented Nov 21, 2021

Apologies for the delays. I have added a new issue for compiling the library at SparseLinearAlgebra/spbla#13

@mlxd
Copy link

mlxd commented Nov 21, 2021

Issue added for adding additional examples: SparseLinearAlgebra/spbla#14

@editorialbot
Copy link
Collaborator

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-46523-4_38 is OK
- 10.1186/1471-2105-14-149 is OK
- 10.1145/2499370.2462159 is OK
- 10.1145/3210259.3210264 is OK
- 10.1007/978-3-030-54832-2_6 is OK
- 10.1145/3322125 is OK
- 10.1016/j.jpdc.2015.06.010 is OK
- 10.1145/2909437.2909442 is OK
- 10.1109/HPEC.2016.7761646 is OK

MISSING DOIs

- 10.1145/3466795 may be a valid DOI for title: GraphBLAST: A High-Performance Linear Algebra-based Graph Framework on the GPU

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3448, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Aug 19, 2022
@Nikoleta-v3
Copy link

@EgorOrachyov there is a missing DOI. Could you please take care of this? 😄

@Nikoleta-v3 Nikoleta-v3 removed the recommend-accept Papers recommended for acceptance in JOSS. label Aug 19, 2022
@Nikoleta-v3
Copy link

Nikoleta-v3 commented Aug 19, 2022

My apologises for only raising the issue now. I was sure I checked the references 😅

@EgorOrachyov
Copy link

@Nikoleta-v3 If I understand you correctly, I have to fix doi 10.1145/3466795 for GraphBLATS paper and updated article sources?

@EgorOrachyov
Copy link

@editorialbot generate pdf

@EgorOrachyov
Copy link

@Nikoleta-v3 Seems to be fixed now

@EgorOrachyov there is a missing DOI. Could you please take care of this? 😄

@editorialbot
Copy link
Collaborator

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Nikoleta-v3
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-46523-4_38 is OK
- 10.1186/1471-2105-14-149 is OK
- 10.1145/2499370.2462159 is OK
- 10.1145/3210259.3210264 is OK
- 10.1007/978-3-030-54832-2_6 is OK
- 10.1145/3322125 is OK
- 10.1016/j.jpdc.2015.06.010 is OK
- 10.48550/ARXIV.1908.01407 is OK
- 10.1145/2909437.2909442 is OK
- 10.1109/HPEC.2016.7761646 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@Nikoleta-v3 Nikoleta-v3 added the recommend-accept Papers recommended for acceptance in JOSS. label Aug 19, 2022
@Nikoleta-v3
Copy link

dear editors please note that I've set the version to be the tagged release v1.0.0. However,

Release v1.0.0 is ok. (I have made new one especially for Zenodo v1.0.0-zenodo, but it is effectively the same thing)

So the Zenodo archive is based on the tagged release v1.0.0-zenodo. Let me know if I should change the version to be v1.0.0-zenodo instead.

@arfon
Copy link
Member

arfon commented Aug 20, 2022

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-46523-4_38 is OK
- 10.1186/1471-2105-14-149 is OK
- 10.1145/2499370.2462159 is OK
- 10.1145/3210259.3210264 is OK
- 10.1007/978-3-030-54832-2_6 is OK
- 10.1145/3322125 is OK
- 10.1016/j.jpdc.2015.06.010 is OK
- 10.48550/ARXIV.1908.01407 is OK
- 10.1145/2909437.2909442 is OK
- 10.1109/HPEC.2016.7761646 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3449, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@arfon
Copy link
Member

arfon commented Aug 20, 2022

@editorialbot accept

@editorialbot
Copy link
Collaborator

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@editorialbot
Copy link
Collaborator

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.03743 joss-papers#3451
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.03743
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Aug 20, 2022
@arfon
Copy link
Member

arfon commented Aug 20, 2022

@mlxd, @bencardoen – many thanks for your reviews here and to @Nikoleta-v3 for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@EgorOrachyov – your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Aug 20, 2022
@editorialbot
Copy link
Collaborator

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.03743/status.svg)](https://doi.org/10.21105/joss.03743)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.03743">
  <img src="https://joss.theoj.org/papers/10.21105/joss.03743/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.03743/status.svg
   :target: https://doi.org/10.21105/joss.03743

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@EgorOrachyov
Copy link

Many thanks to joss community for reviewing and editing this submission. We are very pleased that we have an opportunity to finally publish it 🎉🚀

@bencardoen
Copy link

Congrats on the acceptance @EgorOrachyov
As a general comment, 99% of journals/venues I've interacted with so far could learn a lot of how the review process works here: highly responsive, collaborative, constructive, open, automated where needed, allowing humans to focus on the parts that need human reflection. @arfon @Nikoleta-v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted CMake published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Shell
Projects
None yet
Development

No branches or pull requests

7 participants