-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DIRECT: Deep Image REConstruction Toolkit #4278
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @estenhlConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@georgeyiasemis - Could you please let me know if there is a way for me to access the Docker image? |
@georgeyiasemis Many thanks! If it is not any trouble, could you also please fix the broken link on your documentation page? |
@editorialbot commands |
Hello @estenhl, here are the things you can ask me to do:
|
Thanks for completing your review checklist @estenhl! |
@osorensen I will get this done the week after ISMRM (13th May). |
Thanks @sairamgeethanath! |
Review checklist for @sairamgeethanathConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@georgeyiasemis Great job on the package! I thoroughly enjoyed playing with it for a while. However, I could not get your docker to work.Can you please close the Docker issue that @estenhl and I both reported? I will then check off the remaining items. |
Thanks a lot @sairamgeethanath 👍 ! Yes we will do that! |
@sairamgeethanath The docker issue is fixed! |
I will test it by the end of the week.
Best,
Sairam
…On Mon, May 16, 2022 at 1:53 PM George Yiasemis ***@***.***> wrote:
@georgeyiasemis <https://github.com/georgeyiasemis> Great job on the
package! I thoroughly enjoyed playing with it for a while. However, I could
not get your docker to work.Can you please close the Docker issue
<NKI-AI/direct#191> that @estenhl
<https://github.com/estenhl> and I both reported? I will then check off
the remaining items.
@sairamgeethanath <https://github.com/sairamgeethanath> The docker issue
is fixed!
—
Reply to this email directly, view it on GitHub
<#4278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHLQWAJVPXWAG7NWP33B7ZTVKKDRNANCNFSM5R4FGQRA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Sairam Geethanath, Ph.D.*
“There are plenty of compelling reasons to push MRI to be more powerful,
but that’s one facet of advancing the field. Another is delivering it to
the world.”
|
@georgeyiasemis I have checked off my list. |
Review checklist for @sairamgeethanathConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
@georgeyiasemis, the reviewers have now completed their checklists. I will now read through the paper, and get back to you if I have any suggested changes. In the meantime, could you:
|
@editorialbot recommend-accept |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#3241 If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3241, then you can now move forward with accepting the submission by compiling again with the command |
|
@editorialbot check references |
|
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#3244 If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3244, then you can now move forward with accepting the submission by compiling again with the command |
👋 @georgeyiasemis - I'm the AEiC on duty this week, and I have a few small changes for the paper before we publish it. Please merge NKI-AI/direct#206 or let me know what you disagree with. |
Hi @danielskatz. Thanks for that. Merged it ! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#3247 If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3247, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @georgeyiasemis (George Yiasemis) and co-authors!! And thanks to @estenhl and @sairamgeethanath for reviewing, and @osorensen for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @georgeyiasemis (George Yiasemis)
Repository: https://github.com/NKI-AI/direct
Branch with paper.md (empty if default branch): joss-submission
Version: v1.0.1
Editor: @osorensen
Reviewers: @estenhl, @sairamgeethanath
Archive: 10.5281/zenodo.6594702
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@estenhl & @sairamgeethanath, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @estenhl
📝 Checklist for @sairamgeethanath
The text was updated successfully, but these errors were encountered: