Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: Trash AI: A Web GUI for Serverless Computer Vision Analysis of Images of Trash #5005

Closed
editorialbot opened this issue Dec 12, 2022 · 31 comments
Closed

[PRE REVIEW]: Trash AI: A Web GUI for Serverless Computer Vision Analysis of Images of Trash #5005

editorialbot opened this issue Dec 12, 2022 · 31 comments
Assignees
@arfon @domna @luxaritas
Labels
Makefile pre-review Python Shell Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 12, 2022 •
edited
Loading

Submitting author: @wincowgerDEV (Win Cowger)
Repository: https://github.com/code4sac/trash-ai
Branch with paper.md (empty if default branch):
Version: 1.0
Editor: @arfon
Reviewers: @domna, @luxaritas
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6ffbb0f89e6c928dad6908a02639789b"><img src="https://joss.theoj.org/papers/6ffbb0f89e6c928dad6908a02639789b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6ffbb0f89e6c928dad6908a02639789b/status.svg)](https://joss.theoj.org/papers/6ffbb0f89e6c928dad6908a02639789b)

Author instructions

Thanks for submitting your paper to JOSS @wincowgerDEV. Currently, there isn't a JOSS editor assigned to your paper.

@wincowgerDEV if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Dec 12, 2022
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.17 s (730.4 files/s, 57003.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TypeScript                      37            193            335           2062
Vuejs Component                 23             40             35           1878
Jupyter Notebook                 4              0           1407            758
Python                           3             90            101            609
YAML                            11             57             30            501
JSON                            11              2              0            307
Markdown                         9            114              0            279
Bourne Shell                     6             29              9            248
TeX                              1             14              0            182
make                             5             22             14             74
SVG                              1              0              0             56
JavaScript                       6              0              6             53
HTML                             2              4              2             36
Dockerfile                       2              8              1             24
XML                              1              0              0              9
Sass                             1              1              2              8
-------------------------------------------------------------------------------
SUM:                           123            574           1942           7084
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1335

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.4154370 is OK
- 10.48550/ARXIV.2003.06975 is OK

MISSING DOIs

- 10.1186/s43591-022-00035-1 may be a valid DOI for title: Trash Taxonomy Tool: harmonizing classification systems used to describe trash in environments
- 10.1186/s40965-018-0050-y may be a valid DOI for title: OpenLitterMap.com – Open Data on Plastic Pollution with Blockchain Rewards (Littercoin)

INVALID DOIs

- https://doi.org/10.1029/2019EA000960 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.wasman.2021.12.001 is INVALID because of 'https://doi.org/' prefix

@arfon
Copy link
Member

arfon commented Dec 14, 2022

@wincowgerDEV – thanks for your submission to JOSS. Can you help me understand where the code contributions are for this project? It looks to be a Python-based project but I'm trying to understand if significant aspects of the codebase are indeed in TypeScript.

Any pointers you could give us here would be very welcome. Also as we're managing a backlog of submissions in this area I think it's appropriate to add the waitlisted label for now.

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Dec 14, 2022
@wincowgerDEV
Copy link

wincowgerDEV commented Dec 17, 2022 via email

@wincowgerDEV
Copy link

@wincowgerDEV – thanks for your submission to JOSS. Can you help me understand where the code contributions are for this project? It looks to be a Python-based project but I'm trying to understand if significant aspects of the codebase are indeed in TypeScript.

Any pointers you could give us here would be very welcome. Also as we're managing a backlog of submissions in this area I think it's appropriate to add the waitlisted label for now.

@arfon I got confirmation from the JS team that the JS is written in Typescript. They think that a reviewer familiar with JS could review the Typescript without much challenge.

@wincowgerDEV
Copy link

@editorialbot and @arfon here are some reviewers from the list of potential reviewers I think might be appropriate:

Typescript: luxaritas, matthewbeleck, domna
Python and AI: a2un, MikeHughesKent, versatran01

Let me know if there is anything else I can do to get us moved from the waitlist to active review.

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@wincowgerDEV
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @wincowgerDEV, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@wincowgerDEV
Copy link

updated DOIs code4sac/trash-ai@52380b0

@wincowgerDEV
Copy link

@editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Checklists can only be created once the review has started in the review issue

@arfon
Copy link
Member

arfon commented Jan 22, 2023

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @arfon is now the editor

@arfon arfon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 22, 2023
@arfon
Copy link
Member

arfon commented Jan 22, 2023

@wincowgerDEV – apologies for the delay here. I'm still struggling to understand exactly what this submission is composed of. It looks to be:

  • Some kind of pre-trained ML model for detecting items of trash in images.
  • A web-ui for driving the model (on serverless compute)
  • Some code for deploying the infrastructure

Is that about right? If so, I'm not sure this is eligible for review in JOSS as we don't review ML models here and generally review underlying libraries/codebases that are designed for maintainable extension rather than user-interfaces driving them (which is where the majority of the code in this submission seems to be focused).

To be clear, I'm not entirely convicted about my feedback here but as I conduct my initial assessment here this is where my head is at.

@wincowgerDEV
Copy link

wincowgerDEV commented Jan 22, 2023 via email

@arfon
Copy link
Member

arfon commented Feb 5, 2023

@luxaritas, @domna, @a2un, @MikeHughesKent 👋 would any of you be willing to review this submission for JOSS? The submission under consideration is Trash AI: A Web GUI for Serverless Computer Vision Analysis of Images of Trash

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. You can learn more about the process in these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Based on your experience, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks
Arfon

@domna
Copy link

domna commented Feb 6, 2023

Hi @arfon ,

I would be happy to review the paper. It would be my first review for JOSS. Judging from the reviewer guidelines I feel confident to deliver a good review for the paper. It may just take a little longer since it's my first time and I just need to adapt to the processes.

@luxaritas
Copy link

Would also be a new reviewer, but I'm up for reviewing.

@arfon
Copy link
Member

arfon commented Feb 8, 2023

Awesome stuff, thank you both! I'll add you both now and get the review started.

@arfon
Copy link
Member

arfon commented Feb 8, 2023

@editorialbot add @domna as reviewer

@editorialbot
Copy link
Collaborator Author

@domna added to the reviewers list!

@arfon
Copy link
Member

arfon commented Feb 8, 2023

@editorialbot add @luxaritas as reviewer

@editorialbot
Copy link
Collaborator Author

@luxaritas added to the reviewers list!

@arfon
Copy link
Member

arfon commented Feb 8, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5136.

@arfon
Copy link
Member

arfon commented Feb 8, 2023

Thanks again @domna & @luxaritas – see you over in #5136 where the actual review will take place.

@MikeHughesKent
Copy link

MikeHughesKent commented Feb 10, 2023 via email

@wincowgerDEV wincowgerDEV mentioned this issue Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arfon arfon

@domna domna

@luxaritas luxaritas

Labels
Makefile pre-review Python Shell Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@arfon @domna @luxaritas @wincowgerDEV @MikeHughesKent @editorialbot