Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: parafields: A generator for distributed, stationary Gaussian processes #5615

Closed
editorialbot opened this issue Jul 3, 2023 · 45 comments
Assignees
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 3, 2023

Submitting author: @dokempf (Dominic Kempf)
Repository: https://github.com/parafields/parafields
Branch with paper.md (empty if default branch): joss-paper
Version: v0.3.0
Editor: @diehlpk
Reviewers: @max-little, @shahmoradi
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/74bf5e003d1fe3bab04c107a5d7c1cce"><img src="https://joss.theoj.org/papers/74bf5e003d1fe3bab04c107a5d7c1cce/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/74bf5e003d1fe3bab04c107a5d7c1cce/status.svg)](https://joss.theoj.org/papers/74bf5e003d1fe3bab04c107a5d7c1cce)

Author instructions

Thanks for submitting your paper to JOSS @dokempf. Currently, there isn't a JOSS editor assigned to your paper.

@dokempf if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Jul 3, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (1244.6 files/s, 208531.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             4              0              0           2680
Python                          13            288            371            917
CMake                            4            142             50            853
YAML                             7             54             26            287
Markdown                         3             45              0            161
C++                              1             18              9            148
TeX                              1              2              0            130
Jupyter Notebook                 4              0            820            126
C/C++ Header                     3             22             30             77
TOML                             1              9             21             65
reStructuredText                 3              5             13              3
-------------------------------------------------------------------------------
SUM:                            44            585           1340           5447
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 816

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/MCSE.2021.3083216 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.2565368 is OK

MISSING DOIs

- 10.1137/s1064827592240555 may be a valid DOI for title: Fast and exact simulation of stationary Gaussian processes through circulant embedding of the covariance matrix
- 10.1137/17m1149730 may be a valid DOI for title: Analysis of circulant embedding methods for sampling stationary random fields

INVALID DOIs

- https://doi.org/10.1016/j.advwatres.2016.12.006 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.camwa.2020.06.007 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @dokempf - thanks for your submission. Due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jul 3, 2023
@dokempf
Copy link

dokempf commented Jul 3, 2023

@danielskatz Thanks! Please bear in mind, that the C++ core library https://github.com/parafields/parafields-core/ is also part of this - which increases the code size drastically. In order to keep the legacy C++ use case simple, we decided to keep the C++ and Python code in two separate projects.

@danielskatz
Copy link

So the C++ core library https://github.com/parafields/parafields-core/ is also part of what you are submitting for review?

@dokempf
Copy link

dokempf commented Jul 3, 2023

@danielskatz Yes, it is.

@danielskatz
Copy link

ok, then the scope review isn't needed.

@danielskatz danielskatz removed the query-scope Submissions of uncertain scope for JOSS label Jul 3, 2023
@danielskatz
Copy link

But please do fix the .bib issues

@danielskatz
Copy link

👋 @diehlpk - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented Jul 3, 2023

@danielskatz I can edit but are this week on vacation and nothing will happen for two weeks.

@diehlpk
Copy link
Member

diehlpk commented Jul 3, 2023

@editorialbot add @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@danielskatz
Copy link

Thanks @diehlpk !

@dokempf
Copy link

dokempf commented Jul 4, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.advwatres.2016.12.006 is OK
- 10.1137/s1064827592240555 is OK
- 10.1137/17m1149730 is OK
- 10.1109/MCSE.2021.3083216 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1016/j.camwa.2020.06.007 is OK
- 10.5281/zenodo.2565368 is OK
- 10.2307/1390903 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@dokempf
Copy link

dokempf commented Jul 4, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@diehlpk
Copy link
Member

diehlpk commented Jul 18, 2023

Hi @dokempf I am back at work and will start finding reviewers.

@diehlpk
Copy link
Member

diehlpk commented Jul 18, 2023

Hi @zhenmuw.edu do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jul 18, 2023

Hi @max-little do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jul 18, 2023

Hi @zhenmuw.edu do you have time to review this paper?

@arfon can you please remove this reviewer form the list, since he deleted his GitHub account?

@max-little
Copy link

max-little commented Jul 18, 2023 via email

@diehlpk
Copy link
Member

diehlpk commented Jul 18, 2023

Hi @rlucas7 do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jul 18, 2023

Yes sure, but it will take me about 3 weeks.

On Tue, 18 Jul 2023 at 22:37, Patrick Diehl @.> wrote: Hi @max-little https://github.com/max-little do you have time to review this paper? — Reply to this email directly, view it on GitHub <#5615 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYOOCSAYH52PTA7P4DOPEXLXQ36YLANCNFSM6AAAAAAZ4TBHU4 . You are receiving this because you were mentioned.Message ID: @.>
-- Max Little (www.maxlittle.net) Associate Professor, University of Birmingham Turing Fellow, Alan Turing Institute TED Fellow (fellows.ted.com/profiles/max-little) Visiting Associate Professor, MIT Author: Machine Learning for Signal Processing, Oxford University Press global.oup.com/academic/product/machine-learning-for-signal-processing-9780198714934 Room 138, School of Computer Science University of Birmingham Birmingham B15 2TT UK +44 7710 609564 Skype: dr.max.little

That would be fine.

@diehlpk
Copy link
Member

diehlpk commented Jul 18, 2023

@editorialbot add @max-little as reviewer

@editorialbot
Copy link
Collaborator Author

@max-little added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Jul 31, 2023

Hi @dokempf can you please recommend some reviewers?

@dokempf
Copy link

dokempf commented Jul 31, 2023

@diehlpk Sure! Looking through the reviewers list for people with a background in uncertainty quantification, I found e.g. shahmoradi, AnjaliSandip and ziyiyin97. Not @ing them on purpose - please do so if you approve the suggestions.

@diehlpk
Copy link
Member

diehlpk commented Jul 31, 2023

Hi @shahmoradi do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jul 31, 2023

Hi @AnjaliSandip do you have time to review this paper?

@AnjaliSandip
Copy link

Unfortunately, I will not be able to complete the review within the next 3 weeks.

@shahmoradi
Copy link

Yes, I can. But it may take until around August 20th or so to complete.

@diehlpk
Copy link
Member

diehlpk commented Jul 31, 2023

@editorialbot add @shahmoradi as reviewer

@editorialbot
Copy link
Collaborator Author

@shahmoradi added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Jul 31, 2023

Yes, I can. But it may take until around August 20th or so to complete.

That is fine with me.

@diehlpk
Copy link
Member

diehlpk commented Jul 31, 2023

Unfortunately, I will not be able to complete the review within the next 3 weeks.

That is no requirement and you still can review the paper if you like.

@diehlpk
Copy link
Member

diehlpk commented Aug 4, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5735.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

7 participants