Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Stokesian Dynamics in Python #5907

Closed
editorialbot opened this issue Oct 1, 2023 · 39 comments
Closed

[PRE REVIEW]: Stokesian Dynamics in Python #5907

editorialbot opened this issue Oct 1, 2023 · 39 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 1, 2023

Submitting author: @Pecnut (Adam K. Townsend)
Repository: https://github.com/Pecnut/stokesian-dynamics
Branch with paper.md (empty if default branch):
Version: 2.1.0
Editor: @philipcardiff
Reviewers: @rajeshrinet, @szwiep
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/02b1f1534aa9d721f7cfa1e67a582ef4"><img src="https://joss.theoj.org/papers/02b1f1534aa9d721f7cfa1e67a582ef4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/02b1f1534aa9d721f7cfa1e67a582ef4/status.svg)](https://joss.theoj.org/papers/02b1f1534aa9d721f7cfa1e67a582ef4)

Author instructions

Thanks for submitting your paper to JOSS @Pecnut. Currently, there isn't a JOSS editor assigned to your paper.

@Pecnut if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Oct 1, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (493.4 files/s, 127527.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          29           1404           1650           6629
Fortran 77                       4              7            312            694
Markdown                         8            278              0            519
TeX                              1              5              0             79
YAML                             2              5              4             41
JSON                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            45           1699           1966           7965
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1146/annurev.fl.20.010188.000551 is OK
- 10.1063/1.5031860 is OK
- 10.1063/1.4989929 is OK
- 10.1007/s10665-017-9935-5 is OK
- 10.1016/j.jnnfm.2018.08.010 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 769

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Underworld2: Python Geodynamics Modelling for Desktop, HPC and Cloud
Submitting author: @jmansour
Handling editor: @leouieda (Retired)
Reviewers: @gassmoeller, @gabersyd
Similarity score: 0.8097

pySBeLT: A Python software package for stochastic sediment transport under rarefied conditions
Submitting author: @szwiep
Handling editor: @kbarnhart (Retired)
Reviewers: @pfeiffea, @tdoane
Similarity score: 0.8055

pyro: a framework for hydrodynamics explorations and prototyping
Submitting author: @harpolea
Handling editor: @labarba (Retired)
Reviewers: @mikaem, @ngoldbaum
Similarity score: 0.8041

PySD: System Dynamics Modeling in Python
Submitting author: @rogersamso
Handling editor: @pdebuyl (Active)
Reviewers: @blsqr, @sixpearls
Similarity score: 0.8018

PySDM v1: particle-based cloud modeling package for warm-rain microphysics and aqueous chemistry
Submitting author: @piotrbartman
Handling editor: @dhhagan (Active)
Reviewers: @darothen, @josephhardinee
Similarity score: 0.7959

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

@editorialbot invite @philipcardiff as editor

Hi @philipcardiff, could you edit this submission?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@philipcardiff
Copy link

Hi @kyleniemeyer, yes, I am happy to edit this!

@philipcardiff
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @philipcardiff is now the editor

@philipcardiff
Copy link

Hi @jmansour, would you be interested in reviewing this submission?

@philipcardiff
Copy link

Hi @harpolea, would you be interested in reviewing this submission?

@philipcardiff
Copy link

Hi @piotrbartman, would you be interested in reviewing this submission?

@philipcardiff
Copy link

Hi @rogersamso, would you be interested in reviewing this submission?

@rogersamso
Copy link

Hi @rogersamso, would you be interested in reviewing this submission?

Hi @philipcardiff, thanks for contacting. Unfortunately, I cannot afford to take any extra workload currently.
Good luck with finding reviewers.
Best

@piotrbartman
Copy link

@philipcardiff thank you for considering me, but I'm currently unable to commit the necessary time for a review

@jmansour
Copy link

@philipcardiff thanks for the consideration, but I won't be able to assist with a review on this occasion.

Best to the authors with their submission.

@philipcardiff
Copy link

@rogersamso , @piotrbartman , @jmansour: No problems, thanks anyway.

Can you recommend a suitable reviewer? For example, would one of your co-authors be suitable to review this submission?

@philipcardiff
Copy link

Hi @szwiep, would you be interested in reviewing this submission?

@philipcardiff
Copy link

Hi @rajeshrinet, would you be interested in reviewing this submission? It seems similar to your PyStokes package.

@jmansour
Copy link

@philipcardiff, you could try @rbeucher and @julesghub.

@rajeshrinet
Copy link

@philipcardiff I would be happy to review this over the next couple of weeks.

@philipcardiff
Copy link

@philipcardiff, you could try @rbeucher and @julesghub.

Thanks, @jmansour, for the suggestions.

@rbeucher, @julesghub: would you be interested in reviewing this submission?

@philipcardiff
Copy link

@philipcardiff I would be happy to review this over the next couple of weeks.

Thanks @rajeshrinet

@philipcardiff
Copy link

@editorialbot add @rajeshrinet as reviewer

@editorialbot
Copy link
Collaborator Author

@rajeshrinet added to the reviewers list!

@szwiep
Copy link

szwiep commented Oct 19, 2023

@philipcardiff, thanks for the consideration. I’m comfortable reviewing the functionality and packaging of the project, but don’t think I have the appropriate amount of domain knowledge. Perhaps my co-author @smchartrand might be a better fit as a reviewer, if he has the time?

@philipcardiff
Copy link

Thanks @szwiep,

@smchartrand are you interested in reviewing this submission?

@smchartrand
Copy link

smchartrand commented Oct 23, 2023 via email

@philipcardiff
Copy link

@philipcardiffhttps://github.com/philipcardiff, I would normally be happy to provide a review. However, at the moment I am reviewing a different submission for JOSS, so my time is limited. Please keep me in mind for any submissions in the future where I may be of help. thanks,

No problem (sorry, I should have checked!); thanks anyway.

@philipcardiff
Copy link

Hi @szwiep, would you still be happy to review this submission? I appreciate that your review would focus on the functionality rather than the domain, however, the other reviewer (@rajeshrinet) will provide a complementary perspective.

@szwiep
Copy link

szwiep commented Nov 1, 2023

Hi @philipcardiff, yes, if that works for all parties involved then I'd be happy to review the package over the next couple of weeks.

@philipcardiff
Copy link

Thanks @szwiep

@philipcardiff
Copy link

@editorialbot add @szwiep as reviewer

@editorialbot
Copy link
Collaborator Author

@szwiep added to the reviewers list!

@philipcardiff
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6011.

@philipcardiff
Copy link

@rajeshrinet, @szwiep, we can continue the discussion at the review issue (#6011)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants