-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: libEnsemble: A complete Python toolkit for dynamic ensembles of calculations #6031
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@jsoishi, @SergeyYakubov - Thank you for accepting our invitation. This is the review thread. In this GitHub issue please firstly type
to generate your checklist. In that list, each reviewer has a checklist of review items. When you complete a corresponding task, please check the box. The review is interactive, so you can open new issues in the software repository and interact with the other reviewers, the author, and the editor. Do not hesitate to ask me anything when you get into any trouble. Have a nice reviewing! |
Review checklist for @jsoishiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @SergeyYakubovConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @jmlarson1, I started looking into your paper. Looks pretty interesting. Couple of issues as of now:
|
Hi @SergeyYakubov, we have fixed the tutorial. I have also updated our local copy of the paper to provide a target audience. The addition is quite brief, but I think as we describe example use cases above, this may be sufficient. Let me know if you think it would be useful to add more clarification. |
@jsoishi, @SergeyYakubov - Could you please update your status and continue to review? Thank you in advance, have a nice week. |
@jbytecode - I've completed my review. I think the paper is well-written, and the software itself is promising. It is somewhat similar to what Apache Spark & Co does in the cloud, but more lightweight and developed with HPC in mind (I was not able to verify it works properly on a large supercomputer, though). Thank you for inviting me. |
@SergeyYakubov - Thank you! |
@jbytecode I apologize for the delay in my review. I should have it finished by the end of this week. |
@jsoishi - no worries, thank you for the reply. |
@editorialbot generate pdf |
@jbytecode I have finished my review. I am also generally impressed with the paper and software. I was able to test the examples on our SLURM-managed cluster. |
@jsoishi - thank you for your review. @jmlarson1 - now we can go on with our editorial tasks |
@editorialbot check references |
|
@editorialbot generate pdf |
@editorialbot generate pdf |
@jbytecode The anchor/crossref to the section header wasn't working correctly, so I've explicitly added a markdown anchor. I find that pointing to that has resolved the issue, right? |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4850, then you can now move forward with accepting the submission by compiling again with the command |
@jmlarson1 - as track editor, I'll proofread this later today and let you know what else, if anything, is needed |
@jmlarson1 - I note the author order in the zenodo archive is different than in the paper. I'm just pointing this out in case you want to make them consistent. |
@jmlarson1 - I've suggested a few small changes in Libensemble/libensemble#1199 - please merge this, or let me know what you disagree with, and then we can proceed |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4851, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Thank you for your edits. I've updated the Zenodo author order. |
Congratulations to @jmlarson1 (Jeffrey Larson) and co-authors on your publication!! And thanks to @jsoishi and @SergeyYakubov for reviewing, and to @jbytecode for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jmlarson1 (Jeffrey Larson)
Repository: https://github.com/Libensemble/libensemble
Branch with paper.md (empty if default branch): joss-develop
Version: v1.1.0
Editor: @jbytecode
Reviewers: @jsoishi, @SergeyYakubov
Archive: 10.5281/zenodo.10391387
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jsoishi & @SergeyYakubov, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jsoishi
📝 Checklist for @SergeyYakubov
The text was updated successfully, but these errors were encountered: