[PRE REVIEW]: G'MIC: An Open-Source Self-Extending Framework for Image Processing

[editorialbot]

Submitting author: @dtschump (David Tschumperlé)
Repository: https://github.com/GreycLab/gmic
Branch with paper.md (empty if default branch): joss
Version: 3.3.2
Editor: @gkthiruvathukal
Reviewers: @jamesrhester, @Smattr, @drj11
Managing EiC: Daniel S. Katz

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8"><img src="https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8/status.svg)](https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8)

Author instructions

Thanks for submitting your paper to JOSS @dtschump. Currently, there isn't a JOSS editor assigned to your paper.

@dtschump if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (228.7 files/s, 47869.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         1            156              0            499
SVG                              1              5              1            357
TeX                              1             22              0            179
YAML                             2              1              4             19
make                             1              4              0              9
-------------------------------------------------------------------------------
SUM:                             6            188              5           1063
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 6734

[editorialbot]

Failed to discover a valid open source license

[editorialbot]

Failed to discover a Statement of need section in paper

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1109/icip46576.2022.9897386 may be a valid DOI for title: Automatic Illumination of Flat-Colored Drawings by 3D Augmentation of 2D Silhouettes
- 10.1109/icip46576.2022.9897334 may be a valid DOI for title: A Patch-Based Approach for Artistic Style Transfer via Constrained Multi-Scale Image Matching
- 10.1137/19m1306798 may be a valid DOI for title: Reconstruction of Smooth 3D Color Functions from Keypoints: Application to Lossy Compression and Exemplar-Based Generation of Color LUTs
- 10.1109/tip.2015.2411437 may be a valid DOI for title: Exemplar-based inpainting: Technical review and new heuristics for better geometric reconstructions
- 10.1109/99.660313 may be a valid DOI for title: OpenMP: an industry standard API for shared-memory programming
- 10.1038/s41586-023-06551-1 may be a valid DOI for title: Outflows from the youngest stars are mostly molecular

INVALID DOIs

- None

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[danielskatz]

@dtschump - Can you add the full software to the joss branch (so that this is copy of master, with the paper, rather than just the paper)?

[danielskatz]

In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

[danielskatz]

Finally (for now), your paper is not a JOSS paper: it's about 7000 words long, while JOSS papers are typically around 1000 words. Much of what is in your paper might be replaced by links to documentation or something else. The JOSS paper should just be a brief introduction to the software.

Please follow the example paper You can use the command @editorialbot generate pdf after making changes to the .md file to make a new PDF.

[dtschump]

Hello @danielskatz . Thanks for your inspection.
I'm currently trying to fix the issues, and I'll reduce the length of the paper as well.

[dtschump]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/icip46576.2022.9897386 is OK
- 10.1109/icip46576.2022.9897334 is OK
- 10.1137/19m1306798 is OK
- 10.1109/tip.2015.2411437 is OK
- 10.1109/99.660313 is OK
- 10.1038/s41586-023-06551-1 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[dtschump]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.15 s (380.3 files/s, 309496.6 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            286              0            792
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           3023           1805          40750
--------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 4292

[editorialbot]

Failed to discover a Statement of need section in paper

[dtschump]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.16 s (355.3 files/s, 288913.6 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            276              0            764
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           3013           1805          40722
--------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 3829

[editorialbot]

Failed to discover a Statement of need section in paper

[dtschump]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.18 s (305.8 files/s, 248199.3 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            254              0            693
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           2991           1805          40651
--------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 2321

[dtschump]

I'm not sure if I can help at this point, but feel free to ask me any questions if any.

[dominiquesydow]

Hi @gkthiruvathukal, my sincere apologies, I am afraid this topic is too far outside of my expertise to be a useful reviewer.

[gkthiruvathukal]

@jamesrhester It isn't required to have deep expertise to review JOSS submissions. Having prior experience with image processing tools is a plus. The goal is to evaluate that the software does what the authors say it does and meets the JOSS requirements. I'm going to go ahead and assign you and see if I can find a second reviewer in the meantime.

[gkthiruvathukal]

@editorialbot add @jamesrhester as reviewer

[editorialbot]

@jamesrhester added to the reviewers list!

[gkthiruvathukal]

@jsgalan are you willing to review this JOSS submission?

[jamesrhester]

Just to note, I don't believe I can start the review until all reviewers are in place and a new issue is created.

[danielskatz]

👋 @gkthiruvathukal - this submission seems stuck - can you help move it forward?

[gkthiruvathukal]

@danielskatz Apologies for the delays on my end. The past few weeks have been super busy with my chairperson duties. I'll try to keep this moving.

Working to get a second reviewer now.

[gkthiruvathukal]

@Smattr Would you be willing to help with this JOSS submission? I need a second reviewer in order to proceed with review.

[danielskatz]

@gkthiruvathukal - thanks. We usually recommend to editors that they ask a few different potential reviewers at a time, rather than doing it serially, if possible.

[gkthiruvathukal]

@danielskatz See above! I did ask multiple. One already responded in the affirmative. (Thanks, @jamesrhester!)

[Smattr]

Thanks for considering me, but unfortunately my time’s full for the next little while. If you can’t find anyone else, I should have some time in May.

[gkthiruvathukal]

@Smattr Can I go ahead and add you? I'm willing to work with your timeframe. I'd rather get things moving than not have them moving at all.

[drj11]

i can review. I'm not exactly expert, but i have written the pure-Python PNG module PyPNG https://gitlab.com/drj11/pypng

[danielskatz]

@gkthiruvathukal - it seems like you can add @drj11 and @Smattr , as we're getting close to May, and then start the review?

[gkthiruvathukal]

@danielskatz Sorry for the delay on this one. Got things going and then hit a wall of work (again).

[gkthiruvathukal]

@editorialbot add @drj11

[editorialbot]

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

[gkthiruvathukal]

@Smattr It is almost May, so I am going to add you! Please take the time you need.
@drj11 Thank you for also being willing!

[gkthiruvathukal]

@editorialbot add @Smattr as reviewer

[editorialbot]

@Smattr added to the reviewers list!

[gkthiruvathukal]

@editorialbot add @drj11 as reviewer

[editorialbot]

@drj11 added to the reviewers list!

[gkthiruvathukal]

@editorialbot start review

[editorialbot]

OK, I've started the review over in #6618.