-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: G'MIC: An Open-Source Self-Extending Framework for Image Processing #6618
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Review checklist for @jamesrhesterConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @drj11Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jamesrhester, @Smattr, @drj11 Have you been able to get started with this JOSS review? |
👋 @gkthiruvathukal, @jamesrhester, @Smattr, @drj11 - I want to check on the progress of this review. Is there anything blocking its progress? |
Just haven't got to it yet, nothing blocking.
…On Mon, 27 May 2024 at 17:39, Daniel S. Katz ***@***.***> wrote:
👋 @gkthiruvathukal <https://github.com/gkthiruvathukal>, @jamesrhester
<https://github.com/jamesrhester>, @Smattr <https://github.com/Smattr>,
@drj11 <https://github.com/drj11> - I want to check on the progress of
this review. Is there anything blocking its progress?
—
Reply to this email directly, view it on GitHub
<#6618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF2GPWYHNE26CZ4WFQ3ONDZELPJVAVCNFSM6AAAAABGFYPTXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSHA2DANJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
T +61 (02) 9717 9907
F +61 (02) 9717 3145
M +61 (04) 0249 4148
|
Thanks, @jamesrhester. Do you have an ETA? @Smattr, @drj11, can you let us know whether you can complete your review? We need at least two completed reviews to proceed. |
Like jamesrhester, I just haven’t had time yet. My previous comment about not being available until May was not a request to be assigned as a reviewer, assuming I would immediately start May 1 😉. I think I should have some time upcoming, but fair warning I have not taken even a cursory glance at the paper yet to see if I’m qualified to review. |
i have been on holiday and i'm back now. i've had a poke around their documentation, and i don't see a problem with proceeding. I'll try it and get it done by Friday. 2024-06-07 |
Review checklist for @SmattrConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
FYI for other reviewers, as per GreycLab/gmic#55 (comment) apparently we’re supposed to review the release tarball not the current content on Github. |
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6315, then you can now move forward with accepting the submission by compiling again with the command |
@dtschump - I've suggested a number of changes in GreycLab/gmic#94, and also note that you don't have an acknowledgments section, which could be used to mention funding, if needed. Can you merge the changes, or let me know what you disagree with? |
Hello @danielskatz . I've also added an "Acknowledgements" section, as suggested, with commit: GreycLab/gmic@d522b0f Thanks for the suggestion! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6318, then you can now move forward with accepting the submission by compiling again with the command |
@dtschump - Can you check the "final" proof above and verify that it all looks good to you? |
@danielskatz , I've read the proof and found a single issue, that is fixed with: GreycLab/gmic@23e1178 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6319, then you can now move forward with accepting the submission by compiling again with the command |
@danielskatz Looks good to me now, sorry for the inconvenience :) |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @dtschump (David Tschumperlé) and co-authors on your publication!! And thanks to @jamesrhester, @Smattr, and @NicholasSynovic for reviewing, and to @gkthiruvathukal for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks @danielskatz and thanks to the reviewers! 🎆 |
Congrats @dtschump! And sorry it was such a long road. |
@Smattr , In France, there's a saying that free software supporters often use: “The road is long, but the path is free”. |
@dtschump Congrats and thank you for your incredible patience! |
Submitting author: @dtschump (David Tschumperlé)
Repository: https://github.com/GreycLab/gmic
Branch with paper.md (empty if default branch): joss
Version: 3.4.3
Editor: @gkthiruvathukal
Reviewers: @jamesrhester, @Smattr, @NicholasSynovic
Archive: 10.5281/zenodo.13936919
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jamesrhester & @Smattr & @drj11, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @gkthiruvathukal know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jamesrhester
📝 Checklist for @Smattr
📝 Checklist for @NicholasSynovic
The text was updated successfully, but these errors were encountered: