Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: G'MIC: An Open-Source Self-Extending Framework for Image Processing #6618

Closed
editorialbot opened this issue Apr 13, 2024 · 145 comments
Closed
Assignees
Labels
accepted C++ CMake HTML JavaScript Makefile published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 13, 2024

Submitting author: @dtschump (David Tschumperlé)
Repository: https://github.com/GreycLab/gmic
Branch with paper.md (empty if default branch): joss
Version: 3.4.3
Editor: @gkthiruvathukal
Reviewers: @jamesrhester, @Smattr, @NicholasSynovic
Archive: 10.5281/zenodo.13936919

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8"><img src="https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8/status.svg)](https://joss.theoj.org/papers/3a7bf663fe762a18b348e74ddfc568c8)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@jamesrhester & @Smattr & @drj11, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @gkthiruvathukal know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @jamesrhester

📝 Checklist for @Smattr

📝 Checklist for @NicholasSynovic

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.13 s (431.0 files/s, 349651.7 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
C++                               3            920            755          13939
SVG                               5             12              4          11995
JavaScript                       13           1127            207           9089
CSS                               3            160             68           1615
HTML                              6            116             70           1295
Markdown                          3            250              0            676
make                              3            112            331            589
CMake                             7             87             70            390
Bourne Again Shell                5             66            101            387
C/C++ Header                      1             99             94            382
TeX                               1             22              0            185
XML                               1              0              0             36
Scheme                            1             10             45             31
YAML                              2              1              4             19
Bourne Shell                      2              5             56              6
--------------------------------------------------------------------------------
SUM:                             56           2987           1805          40634
--------------------------------------------------------------------------------

Commit count by author:

  1089	David Tschumperle
     1	Garry R. Osgood

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/icip46576.2022.9897386 is OK
- 10.1109/icip46576.2022.9897334 is OK
- 10.1137/19m1306798 is OK
- 10.1109/tip.2015.2411437 is OK
- 10.1109/99.660313 is OK
- 10.1038/s41586-023-06551-1 is OK

MISSING DOIs

- No DOI given, and none found for title: ImageMagick
- No DOI given, and none found for title: GraphicsMagick
- No DOI given, and none found for title: CImg: C++ Template Image Processing Toolkit
- No DOI given, and none found for title: G’MIC: GREYC’s Magic for Image Computing
- No DOI given, and none found for title: A fast and efficient semi-guided algorithm for fla...
- No DOI given, and none found for title: A non-local algorithm for image denoising
- No DOI given, and none found for title: Mémoire sur l’itération des fonctions rationnelles
- No DOI given, and none found for title: The Buddhabrot Technique
- No DOI given, and none found for title: Lineart Bucket Fill
- No DOI given, and none found for title: Fractalius.
- No DOI given, and none found for title: David Revoy, Comic book artist and Art Director
- No DOI given, and none found for title: Pepper & Carrot, A free(libre) and open-source web...
- No DOI given, and none found for title: The MathMap Image Processing Application
- No DOI given, and none found for title: Pixelitor
- No DOI given, and none found for title: Filter Forge
- No DOI given, and none found for title: A cross-platform software for creating graphical u...
- No DOI given, and none found for title: A neural algorithm of artistic style

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1576

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jamesrhester
Copy link

jamesrhester commented Apr 13, 2024

Review checklist for @jamesrhester

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/GreycLab/gmic?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@dtschump) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@drj11
Copy link

drj11 commented Apr 14, 2024

Review checklist for @drj11

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/GreycLab/gmic?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@dtschump) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@gkthiruvathukal
Copy link

@jamesrhester, @Smattr, @drj11 Have you been able to get started with this JOSS review?

@danielskatz
Copy link

👋 @gkthiruvathukal, @jamesrhester, @Smattr, @drj11 - I want to check on the progress of this review. Is there anything blocking its progress?

@jamesrhester
Copy link

jamesrhester commented May 27, 2024 via email

@gkthiruvathukal
Copy link

Thanks, @jamesrhester. Do you have an ETA?

@Smattr, @drj11, can you let us know whether you can complete your review? We need at least two completed reviews to proceed.

@Smattr
Copy link

Smattr commented May 28, 2024

Like jamesrhester, I just haven’t had time yet. My previous comment about not being available until May was not a request to be assigned as a reviewer, assuming I would immediately start May 1 😉. I think I should have some time upcoming, but fair warning I have not taken even a cursory glance at the paper yet to see if I’m qualified to review.

@drj11
Copy link

drj11 commented Jun 3, 2024

i have been on holiday and i'm back now. i've had a poke around their documentation, and i don't see a problem with proceeding. I'll try it and get it done by Friday. 2024-06-07

@gkthiruvathukal
Copy link

Thanks, @Smattr and @drj11. No worries. Happy to have you on board!

@Smattr
Copy link

Smattr commented Jun 8, 2024

Review checklist for @Smattr

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/GreycLab/gmic?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@dtschump) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@Smattr
Copy link

Smattr commented Jun 17, 2024

FYI for other reviewers, as per GreycLab/gmic#55 (comment) apparently we’re supposed to review the release tarball not the current content on Github.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1201/9781003323693 is OK
- 10.1109/icip46576.2022.9897386 is OK
- 10.1109/icip46576.2022.9897334 is OK
- 10.1137/19m1306798 is OK
- 10.1109/tip.2015.2411437 is OK
- 10.1109/99.660313 is OK
- 10.1167/16.12.326 is OK
- 10.1038/s41586-023-06551-1 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ImageMagick
- No DOI given, and none found for title: GraphicsMagick
- No DOI given, and none found for title: G’MIC: GREYC’s Magic for Image Computing
- No DOI given, and none found for title: A fast and efficient semi-guided algorithm for fla...
- No DOI given, and none found for title: A non-local algorithm for image denoising
- No DOI given, and none found for title: Mémoire sur l’itération des fonctions rationnelles
- No DOI given, and none found for title: The Buddhabrot Technique
- No DOI given, and none found for title: Lineart Bucket Fill
- No DOI given, and none found for title: Fractalius.
- No DOI given, and none found for title: David Revoy, Comic book artist and Art Director
- No DOI given, and none found for title: Pepper & Carrot, A free(libre) and open-source web...
- No DOI given, and none found for title: The MathMap Image Processing Application
- No DOI given, and none found for title: Pixelitor
- No DOI given, and none found for title: Filter Forge
- No DOI given, and none found for title: A cross-platform software for creating graphical u...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6315, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@danielskatz
Copy link

@dtschump - I've suggested a number of changes in GreycLab/gmic#94, and also note that you don't have an acknowledgments section, which could be used to mention funding, if needed.

Can you merge the changes, or let me know what you disagree with?
And then consider adding an acknowledgments section?

@dtschump
Copy link

dtschump commented Jan 9, 2025

Hello @danielskatz .
I've merged your changes, thanks a lot for the corrections.

I've also added an "Acknowledgements" section, as suggested, with commit: GreycLab/gmic@d522b0f

Thanks for the suggestion!

@danielskatz
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1201/9781003323693 is OK
- 10.1109/icip46576.2022.9897386 is OK
- 10.1109/icip46576.2022.9897334 is OK
- 10.1137/19m1306798 is OK
- 10.1109/tip.2015.2411437 is OK
- 10.1109/99.660313 is OK
- 10.1167/16.12.326 is OK
- 10.1038/s41586-023-06551-1 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ImageMagick
- No DOI given, and none found for title: GraphicsMagick
- No DOI given, and none found for title: G’MIC: GREYC’s Magic for Image Computing
- No DOI given, and none found for title: A fast and efficient semi-guided algorithm for fla...
- No DOI given, and none found for title: A non-local algorithm for image denoising
- No DOI given, and none found for title: Mémoire sur l’itération des fonctions rationnelles
- No DOI given, and none found for title: The Buddhabrot Technique
- No DOI given, and none found for title: Lineart Bucket Fill
- No DOI given, and none found for title: Fractalius.
- No DOI given, and none found for title: David Revoy, Comic book artist and Art Director
- No DOI given, and none found for title: Pepper & Carrot, A free(libre) and open-source web...
- No DOI given, and none found for title: The MathMap Image Processing Application
- No DOI given, and none found for title: Pixelitor
- No DOI given, and none found for title: Filter Forge
- No DOI given, and none found for title: A cross-platform software for creating graphical u...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6318, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@danielskatz
Copy link

@dtschump - Can you check the "final" proof above and verify that it all looks good to you?

@dtschump
Copy link

dtschump commented Jan 9, 2025

@danielskatz , I've read the proof and found a single issue, that is fixed with: GreycLab/gmic@23e1178
(link to G'MIC-Qt github repo was not correct anymore, as it moved from Sebastien Fourey's account to the GREYC account, after his passing).

@danielskatz
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1201/9781003323693 is OK
- 10.1109/icip46576.2022.9897386 is OK
- 10.1109/icip46576.2022.9897334 is OK
- 10.1137/19m1306798 is OK
- 10.1109/tip.2015.2411437 is OK
- 10.1109/99.660313 is OK
- 10.1167/16.12.326 is OK
- 10.1038/s41586-023-06551-1 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ImageMagick
- No DOI given, and none found for title: GraphicsMagick
- No DOI given, and none found for title: G’MIC: GREYC’s Magic for Image Computing
- No DOI given, and none found for title: A fast and efficient semi-guided algorithm for fla...
- No DOI given, and none found for title: A non-local algorithm for image denoising
- No DOI given, and none found for title: Mémoire sur l’itération des fonctions rationnelles
- No DOI given, and none found for title: The Buddhabrot Technique
- No DOI given, and none found for title: Lineart Bucket Fill
- No DOI given, and none found for title: Fractalius.
- No DOI given, and none found for title: David Revoy, Comic book artist and Art Director
- No DOI given, and none found for title: Pepper & Carrot, A free(libre) and open-source web...
- No DOI given, and none found for title: The MathMap Image Processing Application
- No DOI given, and none found for title: Pixelitor
- No DOI given, and none found for title: Filter Forge
- No DOI given, and none found for title: A cross-platform software for creating graphical u...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6319, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@dtschump
Copy link

dtschump commented Jan 9, 2025

@danielskatz Looks good to me now, sorry for the inconvenience :)

@danielskatz
Copy link

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Tschumperlé
  given-names: David
  orcid: "https://orcid.org/0000-0003-3454-5079"
- family-names: Fourey
  given-names: Sébastien
  orcid: "https://orcid.org/0000-0001-9293-0771"
- family-names: Osgood
  given-names: Garry
contact:
- family-names: Tschumperlé
  given-names: David
  orcid: "https://orcid.org/0000-0003-3454-5079"
doi: 10.5281/zenodo.13936919
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Tschumperlé
    given-names: David
    orcid: "https://orcid.org/0000-0003-3454-5079"
  - family-names: Fourey
    given-names: Sébastien
    orcid: "https://orcid.org/0000-0001-9293-0771"
  - family-names: Osgood
    given-names: Garry
  date-published: 2025-01-09
  doi: 10.21105/joss.06618
  issn: 2475-9066
  issue: 105
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6618
  title: "G'MIC: An Open-Source Self-Extending Framework for Image
    Processing"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06618"
  volume: 10
title: "G'MIC: An Open-Source Self-Extending Framework for Image
  Processing"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06618 joss-papers#6320
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06618
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Jan 9, 2025
@danielskatz
Copy link

Congratulations to @dtschump (David Tschumperlé) and co-authors on your publication!!

And thanks to @jamesrhester, @Smattr, and @NicholasSynovic for reviewing, and to @gkthiruvathukal for editing!
JOSS fully depends on volunteers and couldn't do this without you

@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following

code snippets

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06618/status.svg)](https://doi.org/10.21105/joss.06618)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06618">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06618/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06618/status.svg
   :target: https://doi.org/10.21105/joss.06618

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@dtschump
Copy link

dtschump commented Jan 9, 2025

Thanks @danielskatz and thanks to the reviewers! 🎆

@Smattr
Copy link

Smattr commented Jan 10, 2025

Congrats @dtschump! And sorry it was such a long road.

@dtschump
Copy link

dtschump commented Jan 10, 2025

@Smattr , In France, there's a saying that free software supporters often use: “The road is long, but the path is free”.
We all know that developing free and/or open-source software is all about patience. :)

@gkthiruvathukal
Copy link

@dtschump Congrats and thank you for your incredible patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted C++ CMake HTML JavaScript Makefile published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

9 participants