-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: AMLTK: A Modular AutoML Toolkit in Python #6367
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @gomezzzConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @eddiebergman, there seem to be some missing references in your paper. Would you be able to fix those and re-generate the PDF? Please include a valid DOI for all references (indeed 10.1109/TPAMI.2021.3067763 is the correct one for your first reference). |
@JBorrow Apologies, I missed that this was required in the |
@editorialbot check references |
|
All looks good now @eddiebergman, thank you. |
(starting to go through the checklist now) |
Hi @gomezzz, The contributions are as follows:
Please let me know if I can further clarify any of these points :) |
Thanks @eddiebergman for the details. I am not sure how this interacts with the authorship guidelines of JOSS and if all these are sufficient for authorship. I have no strong opinions on the matter, I'll check the box and maybe @JBorrow can decide on this aspect if there remains any uncertainty. |
Hi @gomezzz, thank you. I will raise this with the editorial board shortly. In other news, I will be out on vacation until the 24th, so please do not expect any responses before then. |
Review checklist for @hirzelConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi, I read through the paper and the Readme, tried the "pip install", and poked around in the repo as needed to answer the questions in the checklist. Overall, this seems like a nice package. Thank you for submitting it! A couple of suggestions that could make this even better:
Finally, I was wondering if the paper should cite Lale. I hesitate to bring this up, because I am one of the Lale authors. However, I do believe it is quite relevant here for multiple reasons. The first example in the Readme illustrates a >> combinator for pipeline composition, which Lale also provides. The paper emphasizes AMLTK's support for multiple optimizers, which Lale also provides (see Section 4 of the NeurIPS paper). Also, the authors chose me as a reviewer in part because Lale is close related work for AMLTK. That said, if you decide not to cite the Lale paper here, I am fine with that. |
Hi @woznicak, have you had a chance to start on your review yet? |
@editorialbot set https://zenodo.org/records/13309538 as archive |
That doesn't look like a valid DOI value |
@editorialbot set 10.5281/zenodo.13309537 as archive |
Done! archive is now 10.5281/zenodo.13309537 |
@editorialbot set v1.12.1 as version |
Done! version is now v1.12.1 |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5763, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot generate pdf |
🔍 checking out the following:
|
👋 @eddiebergman - I just need you to address the following before I can accept this for publication:
In the paper:
Thanks |
Hi @crvernon, the issues have been addressed! |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🥳 Congratulations on your new publication @eddiebergman! Many thanks to @JBorrow for editing and @gomezzz, @woznicak, and @hirzel for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @eddiebergman (Edward Bergman)
Repository: https://github.com/automl/amltk
Branch with paper.md (empty if default branch): joss-paper
Version: v1.12.1
Editor: @JBorrow
Reviewers: @gomezzz, @woznicak, @hirzel
Archive: 10.5281/zenodo.13309537
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gomezzz & @woznicak & @hirzel, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @JBorrow know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @gomezzz
📝 Checklist for @hirzel
📝 Checklist for @woznicak
The text was updated successfully, but these errors were encountered: