-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: NOMAD CAMELS: Configurable Application for Measurements, Experiments and Laboratory Systems #6371
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @lapmk @NicolasCARPi @ktahar this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering @editorialbot generate my checklist as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#REVIEW_NUMBER so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@srmnitc ) if you have any questions/concerns, thanks again for the submission, and for thr reviews |
On behalf of all co-authors: @NicolasCARPi and @ktahar, thank you very much for your willingness and precious time to review our manuscript. Thanks a lot also to @srmnitc for editing our submission. We look forward to your comments and are happy to answer your questions. |
Review checklist for @NicolasCARPiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Good to know. I was going for the other way around, but I agree with this approach! |
Review checklist for @ktaharConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @NicolasCARPi and @ktahar. First of all, thank you very much for digging so deeply into our NOMAD CAMELS code. This is extremely helpful and will lead to significant improvements. We really appreciate your input. |
@editorialbot generate pdf |
Hello everyone, My checklist is done. All my remarks were promptly and adequately addressed by the dev team. Looks good to me! |
Thanks @NicolasCARPi. @lapmk I see that some of the issues are still open, could you please close them if they have been addressed already? |
Hi @ktahar, hope everything is going well! Are there any issues still open from your side to check the remaining boxes? |
@editorialbot set 1.0.2 as version |
Done! version is now 1.0.2 |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5100, then you can now move forward with accepting the submission by compiling again with the command |
@lapmk Thank you for the submission, I have now passed it on to our EiCs who will take care of the rest of the process. Thanks for responding promptly to all reviewer issues and making the changes. @NicolasCARPi @ktahar once again, thanks for the taking your time to review and provide feedback! |
@srmnitc Thank you very much for taking care of our submission as editor. This review process was really a pleasure, and also gave our software a boost. Thank you all for your time! |
Hi @lapmk, I made a few edits to the paper via FAU-LAP/NOMAD-CAMELS#73, could you review and merge? |
@editorialbot generate pdf |
@kyleniemeyer Thank you very much for your edits. Merged. I understand that you didn't like the examples places in parentheses, however, I would prefer to keep references separate from words in the text if this is acceptable. Thus, I made two minor changes in lines 17-18 and 58 in the compiled manuscript. Is this fine with you? |
@lapmk I think that looks good. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @lapmk on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already. Many thanks to @NicolasCARPi and @ktahar for reviewing this, and @srmnitc for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@kyleniemeyer Thank you very much on behalf of all co-authors! And I've just signed up as a reviewer for JOSS ;-) Again, many thanks to all and see you next time! @srmnitc @NicolasCARPi @ktahar |
Submitting author: @lapmk (Michael Krieger)
Repository: https://github.com/FAU-LAP/NOMAD-CAMELS
Branch with paper.md (empty if default branch): JOSS-paper
Version: 1.0.2
Editor: @srmnitc
Reviewers: @NicolasCARPi, @ktahar
Archive: 10.5281/zenodo.10793952
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@NicolasCARPi & @ktahar, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @srmnitc know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @NicolasCARPi
📝 Checklist for @ktahar
The text was updated successfully, but these errors were encountered: