Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: hf_hydrodata: A Python package for accessing hydrologic simulations and observations across the United States #6378

Closed
editorialbot opened this issue Feb 19, 2024 · 30 comments
Closed

[PRE REVIEW]: hf_hydrodata: A Python package for accessing hydrologic simulations and observations across the United States #6378

editorialbot opened this issue Feb 19, 2024 · 30 comments
Assignees
@alessandroamaranto @thodson-usgs @rwegener2
Labels
pre-review Python Shell TeX Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 19, 2024 •
edited
Loading

Submitting author: @amy-defnet (Amy Defnet)
Repository: https://github.com/hydroframe/hf_hydrodata
Branch with paper.md (empty if default branch):
Version: v1.1.0
Editor: @rwegener2
Reviewers: @thodson-usgs, @alessandroamaranto
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0f71e8275dbff415d2f76e1089c34dc8"><img src="https://joss.theoj.org/papers/0f71e8275dbff415d2f76e1089c34dc8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0f71e8275dbff415d2f76e1089c34dc8/status.svg)](https://joss.theoj.org/papers/0f71e8275dbff415d2f76e1089c34dc8)

Author instructions

Thanks for submitting your paper to JOSS @amy-defnet. Currently, there isn't a JOSS editor assigned to your paper.

@amy-defnet if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Feb 19, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1126/science.aaf7891 is OK
- 10.5194/gmd-14-7223-2021 is OK
- 10.1016/j.jhydrol.2023.130294 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.5281/zenodo.3509134 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.17 s (362.6 files/s, 120342.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          19           1560           2363           6472
reStructuredText                24            256            426            416
Jupyter Notebook                 6              0           8203            256
Markdown                         2             72              0            163
YAML                             2             56             12            119
TeX                              1              4              0             53
TOML                             1              6              2             33
Bourne Shell                     3              1              5             28
DOS Batch                        1              8              1             27
make                             1              4              5             11
HTML                             1              0              0              7
CSS                              1              0              0              6
-------------------------------------------------------------------------------
SUM:                            62           1967          11017           7591
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 986

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Integrated hydrologic model development and postprocessing for GSFLOW using pyGSFLOW
Submitting author: @jlarsen-usgs
Handling editor: @crvernon (Active)
Reviewers: @thurber, @mdbartos, @mdbartos
Similarity score: 0.8383

HydroMT: Automated and reproducible model building and analysis
Submitting author: @dirkeilander
Handling editor: @elbeejay (Active)
Reviewers: @JannisHoch, @mcflugen, <s>@LejoFlores</s>
Similarity score: 0.8299

hddtools: Hydrological Data Discovery Tools
Submitting author: @cvitolo
Handling editor: @arfon (Active)
Reviewers: @karthik
Similarity score: 0.8249

HRDS: A Python package for hierarchical raster datasets
Submitting author: @jhill1
Handling editor: @kthyng (Active)
Reviewers: @edoddridge, @PythonCHB
Similarity score: 0.8232

NeuralHydrology --- A Python library for Deep Learning research in hydrology
Submitting author: @kratzert
Handling editor: @elbeejay (Active)
Reviewers: @ammilten, @chuckaustin, @jhamman
Similarity score: 0.8214

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Feb 19, 2024

Hi @amy-defnet and thanks for your submission! We have a backlog of submissions so I will add this to our waitlist. In the meantime, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. Thanks for your patience.

@kthyng kthyng added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Feb 19, 2024
@amy-defnet
Copy link

Hi @kthyng! Thank you so much for the quick update. I am working with my team to be able to suggest 5 reviewers to you and I will update this thread once we have those.

@amy-defnet
Copy link

Hi @kthyng - my team suggests the following as potential reviewers (as their github handle) from the JOSS reviewer database: rreinecke, JannisHoch, kellykochanski, dvalters, jlarsen-usgs. Thanks!

@kthyng
Copy link

kthyng commented Feb 28, 2024

@rwegener2 would you be up for editing this submission?

@kthyng
Copy link

kthyng commented Feb 28, 2024

@editorialbot invite @rwegener2 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@rwegener2
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @rwegener2 is now the editor

@rwegener2
Copy link

rwegener2 commented Mar 1, 2024 •
edited
Loading

👋 @shulele would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@rwegener2
Copy link

👋 @thodson-usgs would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@thodson-usgs
Copy link

Sure, this is right up my alley.

@rwegener2
Copy link

rwegener2 commented Mar 1, 2024 •
edited
Loading

Lovely, thank you! I'll add you as a reviewer. Once we get an additional reviewer you will get another set of notifications and at that point a review ticket will be opened for you to begin your review.

@rwegener2
Copy link

@editorialbot add @thodson-usgs as reviewer

@editorialbot
Copy link
Collaborator Author

@thodson-usgs added to the reviewers list!

@rwegener2
Copy link

👋 @puruckertom would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@arfon arfon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Mar 24, 2024
@rwegener2
Copy link

👋🏻 @jmp75, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@rwegener2
Copy link

👋🏻 @raoulcollenteur, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@rwegener2
Copy link

👋🏻 @alessandroamaranto, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@alessandroamaranto
Copy link

alessandroamaranto commented Apr 15, 2024 via email

@rwegener2
Copy link

Great, thanks @alessandroamaranto!

@rwegener2
Copy link

@editorialbot add @alessandroamaranto as reviewer

@editorialbot
Copy link
Collaborator Author

@alessandroamaranto added to the reviewers list!

@rwegener2
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6623.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessandroamaranto alessandroamaranto

@thodson-usgs thodson-usgs

@rwegener2 rwegener2

Labels
pre-review Python Shell TeX Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@arfon @kthyng @alessandroamaranto @thodson-usgs @rwegener2 @amy-defnet @editorialbot