Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: StreamPoseML: An End-to-End Open-Source Web Application and Python Toolkit for Real-Time Video Pose Classification and Machine Learning #6392

Closed
editorialbot opened this issue Feb 22, 2024 · 51 comments
Assignees
Labels
accepted JavaScript Jupyter Notebook published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 22, 2024

Submitting author: @mrilikecoding (N Green)
Repository: https://github.com/mrilikecoding/StreamPoseML
Branch with paper.md (empty if default branch):
Version: v0.1.3
Editor: @arfon
Reviewers: @thejasvibr, @imcatta
Archive: 10.5281/zenodo.14298482

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9e420dbe0f1d8d697e7fee11789b3691"><img src="https://joss.theoj.org/papers/9e420dbe0f1d8d697e7fee11789b3691/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9e420dbe0f1d8d697e7fee11789b3691/status.svg)](https://joss.theoj.org/papers/9e420dbe0f1d8d697e7fee11789b3691)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@thejasvibr & @imcatta, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @imcatta

📝 Checklist for @thejasvibr

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=2.32 s (342.0 files/s, 343159.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                           699              0              0         782901
Python                          59            877           1745           3962
Jupyter Notebook                 6              0           5055           1480
JavaScript                       9             57             52            373
Markdown                         5            162              0            326
YAML                             4             18             65            112
Bourne Shell                     4             25             17             90
CSS                              2             12              0             89
TeX                              1              0              0             79
TOML                             1              3              0             24
HTML                             1              3             20             20
Dockerfile                       2              8              2             18
INI                              1              0              0              2
SVG                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                           795           1165           6956         789477
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1181

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1109/anziis.1994.396988 may be a valid DOI for title: Weka: A machine learning workbench
- 10.32614/rj-2009-016 may be a valid DOI for title: Rattle: a data mining GUI for R
- 10.1038/nmeth.2019 may be a valid DOI for title: Fiji: an open-source platform for biological-image analysis
- 10.1093/bioinformatics/btt080 may be a valid DOI for title: eMZed: an open source framework in Python for rapid and interactive development of LC/MS data analysis workflows
- 10.1109/icfhr-2018.2018.00080 may be a valid DOI for title: Deepdiva: a highly-functional python framework for reproducible experiments
- 10.3390/s21113691 may be a valid DOI for title: End-to-end computer vision framework: An open-source platform for research and education

INVALID DOIs

- None

@arfon
Copy link
Member

arfon commented Feb 22, 2024

@thejasvibr, @imcatta – This is the review thread for the paper. All of our communications will happen here from now on.

Please read the "Reviewer instructions & questions" in the first comment above. Please create your checklist typing:

@editorialbot generate my checklist

As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/6392 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@imcatta
Copy link

imcatta commented Feb 22, 2024

Review checklist for @imcatta

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/mrilikecoding/StreamPoseML?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mirlikecoding) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@thejasvibr
Copy link

thejasvibr commented Mar 3, 2024

Review checklist for @thejasvibr

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/mrilikecoding/StreamPoseML?
  • License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@mirlikecoding) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • [] Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@thejasvibr
Copy link

Hi @arfon I ended being double-booked, by saying yes to two submissions in the pre-review phase and being finalised as a reviewer almost at the same time. Would already like to request some more time for this review (i.e. won't be able to make it in 2-4 weeks).

@arfon
Copy link
Member

arfon commented Mar 9, 2024

Hi @arfon I ended being double-booked, by saying yes to two submissions in the pre-review phase and being finalised as a reviewer almost at the same time. Would already like to request some more time for this review (i.e. won't be able to make it in 2-4 weeks).

No problem at all, and thanks for being a willing JOSS reviewer! What about trying to get your review in by mid-late April?

@thejasvibr
Copy link

Hi @arfon I ended being double-booked, by saying yes to two submissions in the pre-review phase and being finalised as a reviewer almost at the same time. Would already like to request some more time for this review (i.e. won't be able to make it in 2-4 weeks).

No problem at all, and thanks for being a willing JOSS reviewer! What about trying to get your review in by mid-late April?

Hi @arfon , yes. Mid-late April sounds doable. Was out of action due to illness, and am getting back to shape.

@arfon
Copy link
Member

arfon commented May 8, 2024

👋 @thejasvibr, @imcatta – it looks like there has been progress by both of you on your reviews, but neither look to be complete. Could you please provide an update on your current status and when you think you will be able to complete your reviews by? Many thanks!

@arfon
Copy link
Member

arfon commented Jun 2, 2024

👋 @thejasvibr, @imcatta – it looks like there has been progress by both of you on your reviews, but neither look to be complete. Could you please provide an update on your current status and when you think you will be able to complete your reviews by? Many thanks!

Just bumping again here. Please give us an update here soon please @thejasvibr & @imcatta

@arfon
Copy link
Member

arfon commented Jun 22, 2024

Just a quick note to say I've emailed both @thejasvibr & @imcatta to ask for an update.

@imcatta
Copy link

imcatta commented Jun 23, 2024

Hi! Sorry for the late reply, for some reason Github notification emails did not show up in my inbox. I can pledge to complete my review within 14 days if that's feasible.

@thejasvibr
Copy link

thejasvibr commented Jun 23, 2024 via email

@mrilikecoding
Copy link

Hello @arfon, thanks for your patience. I have closed out mrilikecoding/StreamPoseML#14 now. I believe with that I have addressed all the issues related to the JOSS submission here. Please let me know if there is anything else, I'm doing some other work on the package this week and next. Cheers.

@arfon
Copy link
Member

arfon commented Nov 24, 2024

Thanks @mrilikecoding! @imcatta – would you mind coming to take a quick look here to see if this all looks good to you?

@imcatta
Copy link

imcatta commented Nov 25, 2024

Everything looks fine to me! All my comments have been adequately addressed

@arfon
Copy link
Member

arfon commented Dec 7, 2024

@mrilikecoding – looks like we're very close to being done here. I will circle back here next week, but in the meantime, please give your own paper a final read to check for any potential typos etc.

After that, could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:

  • The title of the archive is the same as the JOSS paper title
  • That the authors of the archive are the same as the JOSS paper authors
  • I can then move forward with accepting the submission.

@mrilikecoding
Copy link

@arfon sounds good. I've done a final pass and generated a new release. The automatic update on Zenodo didn't work for some reason but I was able to create the archive manually. Here is the new DOI: https://doi.org/10.5281/zenodo.14298482 - let me know if anything looks amiss. Thanks!

@arfon
Copy link
Member

arfon commented Dec 27, 2024

@editorialbot set 10.5281/zenodo.14298482 as archive

@editorialbot
Copy link
Collaborator Author

Done! archive is now 10.5281/zenodo.14298482

@arfon
Copy link
Member

arfon commented Dec 27, 2024

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6285, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Dec 27, 2024
@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: Chainer: A deep learning framework for acceleratin...
- No DOI given, and none found for title: The WEKA data mining software: an update
- No DOI given, and none found for title: DARWIN: A framework for machine learning and compu...
- No DOI given, and none found for title: Teachable Machine: A web-based tool for creating m...

❌ MISSING DOIs

- 10.1109/anziis.1994.396988 may be a valid DOI for title: Weka: A machine learning workbench
- 10.32614/rj-2009-016 may be a valid DOI for title: Rattle: a data mining GUI for R
- 10.1038/nmeth.2019 may be a valid DOI for title: Fiji: an open-source platform for biological-image...
- 10.1093/bioinformatics/btt080 may be a valid DOI for title: eMZed: an open source framework in Python for rapi...
- 10.1109/icfhr-2018.2018.00080 may be a valid DOI for title: Deepdiva: a highly-functional python framework for...
- 10.3390/s21113691 may be a valid DOI for title: End-to-end computer vision framework: An open-sour...

❌ INVALID DOIs

- None

@arfon
Copy link
Member

arfon commented Dec 27, 2024

@mrilikecoding – could you please merge this PR which makes a few formatting fixes to your paper? mrilikecoding/StreamPoseML#25

@mrilikecoding
Copy link

mrilikecoding commented Dec 27, 2024 via email

@arfon
Copy link
Member

arfon commented Dec 27, 2024

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6286, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@arfon
Copy link
Member

arfon commented Dec 27, 2024

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: Chainer: A deep learning framework for acceleratin...
- No DOI given, and none found for title: The WEKA data mining software: an update
- No DOI given, and none found for title: DARWIN: A framework for machine learning and compu...
- No DOI given, and none found for title: Teachable Machine: A web-based tool for creating m...

❌ MISSING DOIs

- 10.1109/anziis.1994.396988 may be a valid DOI for title: Weka: A machine learning workbench
- 10.32614/rj-2009-016 may be a valid DOI for title: Rattle: a data mining GUI for R
- 10.1038/nmeth.2019 may be a valid DOI for title: Fiji: an open-source platform for biological-image...
- 10.1093/bioinformatics/btt080 may be a valid DOI for title: eMZed: an open source framework in Python for rapi...
- 10.1109/icfhr-2018.2018.00080 may be a valid DOI for title: Deepdiva: a highly-functional python framework for...
- 10.3390/s21113691 may be a valid DOI for title: End-to-end computer vision framework: An open-sour...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Trajkova
  given-names: Milka
  orcid: "https://orcid.org/0000-0002-3694-763X"
- family-names: Green
  given-names: Nathaniel
  orcid: "https://orcid.org/0000-0003-0157-7744"
- family-names: Shinohara
  given-names: Minoru
  orcid: "https://orcid.org/0000-0002-9260-0366"
contact:
- family-names: Shinohara
  given-names: Minoru
  orcid: "https://orcid.org/0000-0002-9260-0366"
doi: 10.5281/zenodo.14298482
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Trajkova
    given-names: Milka
    orcid: "https://orcid.org/0000-0002-3694-763X"
  - family-names: Green
    given-names: Nathaniel
    orcid: "https://orcid.org/0000-0003-0157-7744"
  - family-names: Shinohara
    given-names: Minoru
    orcid: "https://orcid.org/0000-0002-9260-0366"
  date-published: 2024-12-27
  doi: 10.21105/joss.06392
  issn: 2475-9066
  issue: 104
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6392
  title: "'StreamPoseML' An End-to-End Open-Source Web Application and
    Python Toolkit for Real-Time Video Pose Classification and Machine
    Learning"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06392"
  volume: 9
title: "'StreamPoseML' An End-to-End Open-Source Web Application and
  Python Toolkit for Real-Time Video Pose Classification and Machine
  Learning"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06392 joss-papers#6287
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06392
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Dec 27, 2024
@mrilikecoding
Copy link

@arfon thanks! Just noting that my handle on the publication post is incorrect. It should be @mrilikecoding - cheers!

@arfon
Copy link
Member

arfon commented Dec 28, 2024

@thejasvibr, @imcatta – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@mrilikecoding – your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Dec 28, 2024
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following

code snippets

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06392/status.svg)](https://doi.org/10.21105/joss.06392)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06392">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06392/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06392/status.svg
   :target: https://doi.org/10.21105/joss.06392

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted JavaScript Jupyter Notebook published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

5 participants