-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Pysewer: A Python Library for Sewer Network Generation in Data Scarce Regions #6430
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @meghnathomasConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @simoninirelandConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @dbdespot! Is there any way to raise an issue with comments/questions in your repository without signing up for the UFZ GitLab service? |
Hi @meghnathomas, I think the easiest and quickest way to do this is to add the reviewers as a "guest" role to the project. Please let me know if that's ok. If it is, please send me your email. |
@dbdespot that sounds good to me, thanks! My email is meghnathomas@utexas.edu |
@meghnathomas Thanks; it turns out that I have to request the admin to add new members via email. I will try to solve this and get back to you as soon as possible. My apologies |
Hi, @meghnathomas @simoninireland. See below regarding creating issues without signing up for the UFZ GitLab service: Please let me know how this goes. |
Thanks @dbdespot! I've logged in with my GitHub account. |
Hi @dbdespot FYI, I am still unable to access Gitlab. I have been seeing this message every time I've tried to log in the past few weeks: Your account is pending approval from your GitLab administrator and hence blocked. In the mean time, I would recommend setting up an alternate forum/platform where Pysewer users can publicly raise issues or questions without having to set up a Gitlab account. |
Hi @meghnathomas, sorry for the confusion. I had the impression that you could have logged in, and everything worked. I added you as a guest, and you should be able to create issues and so on now. In the meantime, I would look into mirroring this repo on GitHub. But for now, please let me know if you can create an issue,. |
Hi @meghnathomas @simoninireland - how this review is going? |
Hi @olexandr-konovalov thank you for checking in! I just created an issue with feedback for the authors over in their repository. |
Hi @meghnathomas, I would like to let you know that I have responded to the feedback directly on the Gitlab repo. Please note that I have made a mirror GIithub repo. |
Hi @olexandr-konovalov I have completed my review of this code and paper (started over here on Gitlab and continued on their Github repository). I am happy to recommend this paper for acceptance! |
Wondereful, thank @meghnathomas! We will now wait for the 2nd review to be completed by @simoninireland |
@kthyng I have recommended acceptance. The only technical issue is that there is a reference to a journal called "npj Clean Water" and whatever was attempted, like |
@dbdespot ah indeed - good to have automated checks, I've missed that while checking the PDF after the reference has been updated, sorry! Indeed page 3, line 81, broken reference to NetworkX. Please fix and make a new version and a new DOI. |
Hi @olexandr-konovalov, here we go once more; new DOI: https://doi.org/10.5281/zenodo.14355668, version number: v0.1.20 |
@editorialbot set 10.5281/zenodo.14355668 as archive |
Done! archive is now 10.5281/zenodo.14355668 |
@editorialbot set v0.1.20 as version |
Done! version is now v0.1.20 |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6243, then you can now move forward with accepting the submission by compiling again with the command |
Wonderful - thanks @dbdespot! This is now passed over to @openjournals/ese-eics team. |
Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!
|
Looks good to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on your new publication @dbdespot! Many thanks to editor @olexandr-konovalov and to reviewers @meghnathomas and @barneydobson for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Note we have a new tool for reviewers! You can go to https://joss.theoj.org/papers/reviewed_by/@your-github-username to see the JOSS submissions you have reviewed, and you can also copy a badge there with the number of your JOSS reviews. @dbdespot If you'd like to join JOSS as a reviewer, please sign up at https://reviewers.joss.theoj.org/join! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @dbdespot (Daneish Despot)
Repository: https://git.ufz.de/despot/pysewer/
Branch with paper.md (empty if default branch):
Version: v0.1.20
Editor: @olexandr-konovalov
Reviewers: @meghnathomas, @barneydobson
Archive: 10.5281/zenodo.14355668
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@meghnathomas & @simoninireland, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @olexandr-konovalov know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @meghnathomas
📝 Checklist for @barneydobson
The text was updated successfully, but these errors were encountered: