-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DynamicOED.jl: A Julia package for solving optimum1 experimental design problems #6605
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Review checklist for @joshuaehConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Had an issue on installation: mathopt/DynamicOED.jl#28 (comment) Resolved problem was on my end. Looks good from my perspective. One minor note that I would add how to add while not in the registry: |
Hey @diehlpk . Thanks for your efforts! If needed, I asked two people I know of if they could jump in for a review:
Let me know if I can provide any more help on this. |
Hi @diehlpk , apologies for the delay, finally moving forward with it! |
Review checklist for @KBodolaiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Overall I'm quite happy with the submission, the text in the paper reads well and the software looks solid! A couple of small things that I noticed while reviewing, preventing me from ticking the last two boxes:
|
Thanks for the review and the approval!
Should be handled via mathopt/DynamicOED.jl#31 |
fantastic, thanks for checking so quickly! I've verified that the examples are now working and provide the expected results. Good to hear about the separate contribution guide, it could be a good idea to mention it in the docs though (thinking of people that may be newer to the Julia ecosystem). |
Hi @imciner2 the other two reviewers finished their reviews. Do you think you can finish your review in the next two weeks? If not I will go ahead with the other two reviews. |
Hi @imciner2 can you please estimate when you will finish your review? |
@editorialbot remove @imciner2 as reviewer |
@imciner2 removed from the reviewers list! |
@editorialbot check references |
|
@AlCap23 The title is wrong on Zendodo. Can you please change the tittle to match with the paper? |
@AlCap23 if you log in to Zenodo, you should be able to edit the title and other meta data. See the screenshot below with one from my projects. I do not have access to your project to change that. |
I've changed the title to DynamicOED.jl: A Julia package for solving optimum1 experimental design problems without the typo :) . Does this work for you @diehlpk ? |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
@AlCap23 you are good now and I recommended the paper for acceptance. |
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5512, then you can now move forward with accepting the submission by compiling again with the command |
@AlCap23 - as the track editor, I've proofread the paper, and suggest the changes in mathopt/DynamicOED.jl#33 Please merge this, or let me know what you disagree with, then we can continue to acceptance and publication. |
Thanks @danielskatz. I've approved the changes and merged. And also thanks to @diehlpk for his guidance and management throughout the review process and @joshuaeh and @KBodolai for the reviews and suggestions! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5513, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @AlCap23 (Julius Martensen)
Repository: https://github.com/mathopt/DynamicOED.jl
Branch with paper.md (empty if default branch):
Version: v0.1.2
Editor: @diehlpk
Reviewers: @KBodolai, @joshuaeh
Archive: 10.5281/zenodo.12084055
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@KBodolai & @imciner2 & @joshuaeh, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @joshuaeh
📝 Checklist for @KBodolai
The text was updated successfully, but these errors were encountered: