Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: COHESIVM: Combinatorial h+/e- Sample Investigation using Voltaic Measurements #7122

Closed
editorialbot opened this issue Aug 20, 2024 · 32 comments
Assignees
Labels
pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 20, 2024

Submitting author: @mxwalbert (Maximilian Wolf)
Repository: https://github.com/mxwalbert/cohesivm
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @RMeli
Reviewers: @ericfell, @enricgrau
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/42b8ef67cb511833d81289249d273bd2"><img src="https://joss.theoj.org/papers/42b8ef67cb511833d81289249d273bd2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/42b8ef67cb511833d81289249d273bd2/status.svg)](https://joss.theoj.org/papers/42b8ef67cb511833d81289249d273bd2)

Author instructions

Thanks for submitting your paper to JOSS @mxwalbert. Currently, there isn't a JOSS editor assigned to your paper.

@mxwalbert if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Aug 20, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.10 s (990.5 files/s, 286109.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                              3             14              0          11151
Scheme                           2             26              0           9545
Python                          40           1022           1170           3917
Markdown                        19            219              0            744
reStructuredText                26            313            480            372
Jupyter Notebook                 4              0            326            113
TeX                              1              8              0             66
TOML                             1              4              2             51
Arduino Sketch                   1              5              0             50
YAML                             3              9             11             49
CSS                              1              7              0             38
INI                              2             13              0             27
-------------------------------------------------------------------------------
SUM:                           103           1640           1989          26123
-------------------------------------------------------------------------------

Commit count by author:

    27	mxwalbert
     3	selinawillswissen

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 407

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: Materials Acceleration Platform: Accelerating Adva...
- No DOI given, and none found for title: Combinatorial and high-throughput materials scienc...
- No DOI given, and none found for title: Bayesian Optimization of Spray Parameters for the ...
- No DOI given, and none found for title: Bluesky’s ahead: a multi-facility collaboration fo...

❌ MISSING DOIs

- 10.1039/d3ma00136a may be a valid DOI for title: Accelerated screening of Cu-Ga-Fe oxide semiconduc...
- 10.6028/jres.117.010 may be a valid DOI for title: Instrument Control (iC)–an open-source software to...
- 10.1063/5.0032116 may be a valid DOI for title: PyMoDAQ: An open-source Python-based software for ...
- 10.21105/joss.06371 may be a valid DOI for title: NOMAD CAMELS: Configurable Application for Measure...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Simmate: a framework for materials science
Submitting author: @jacksund
Handling editor: @rkurchin (Active)
Reviewers: @bocklund, @utf
Similarity score: 0.7460

fuelcell: A Python package and graphical user interface for electrochemical data analysis
Submitting author: @samaygarg
Handling editor: @jgostick (Active)
Reviewers: @jlopata21, @shimpalee
Similarity score: 0.7404

SolvationAnalysis: A Python toolkit for understanding liquid solvation structure in classical molecular dynamics simulations
Submitting author: @orionarcher
Handling editor: @zhubonan (Active)
Reviewers: @amritagos, @arose
Similarity score: 0.7389

Hardware-Control: Instrument control and automation package
Submitting author: @Grant-Giesbrecht
Handling editor: @timtroendle (Retired)
Reviewers: @aquilesC, @untzag, @garrettj403
Similarity score: 0.7312

spectrapepper: A Python toolbox for advanced analysis of spectroscopic data for materials and devices.
Submitting author: @enricgrau
Handling editor: @rkurchin (Active)
Reviewers: @stuartcampbell, @ksunden
Similarity score: 0.7266

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Aug 20, 2024

@mxwalbert, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.
  • Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @RMeli as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@mxwalbert
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1002/anie.200603675 is OK
- 10.1039/D3MA00136A is OK
- 10.6028/jres.117.010 is OK
- 10.1063/5.0032116 is OK
- 10.21105/joss.06371 is OK
- 10.1080/08940886.2019.1608121 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Materials Acceleration Platform: Accelerating Adva...
- No DOI given, and none found for title: Bayesian Optimization of Spray Parameters for the ...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@mxwalbert
Copy link

@mxwalbert, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.
  • Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).

Thank you!

  • I updated the DOIs in the paper.bib,
  • and moved the contributing guidelines from the README to a separate file CONTRIBUTING.md in the repository root.

@RMeli
Copy link

RMeli commented Aug 21, 2024

@Kevin-Mattheus-Moerman thank you for the invitation. I'm wrapping up things at work and I'll be on holidays for the next two weeks. I can edit this submission, but only starting from the 15th of September, if that is acceptable.

@Kevin-Mattheus-Moerman
Copy link
Member

@RMeli yes that's fine. Please assign yourself. Thanks

@RMeli
Copy link

RMeli commented Aug 21, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @RMeli is now the editor

@RMeli
Copy link

RMeli commented Aug 23, 2024

Hi @samaygarg 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7122.

Thank you in advance!

@RMeli
Copy link

RMeli commented Sep 11, 2024

Hi @ericfell 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7122.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Sep 11, 2024

Hi @mdmurbach 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7122.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Sep 23, 2024

Hi @enricgrau 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7122.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

@RMeli
Copy link

RMeli commented Sep 23, 2024

@mxwalbert I'm somewhat struggling to find reviewers for this submission. Do you happen to have some suggestions of potential reviewers that would be happy to take on this review? Many thanks.

@ericfell
Copy link

Hi @ericfell 👋

Would you be interested in reviewing this submission for JOSS (Journal of Open Source Software)?

You can find more information about the submission at the top of this Github issue #7122.

The Journal of Open Source Software (JOSS) is a developer friendly journal for research software packages, with a formal peer-review process that is designed to improve the quality of the software submitted.

Thank you in advance!

Hi @RMeli apologies for the late reply. I'm happy to be a reviewer for this submission!
Thanks,
Eric

@RMeli
Copy link

RMeli commented Sep 23, 2024

@editorialbot add @ericfell as reviewer

Hi @ericfell, thank you very much!

@editorialbot
Copy link
Collaborator Author

@ericfell added to the reviewers list!

@mxwalbert
Copy link

@mxwalbert I'm somewhat struggling to find reviewers for this submission. Do you happen to have some suggestions of potential reviewers that would be happy to take on this review? Many thanks.

Dear @RMeli, first of all, thank you for handling our submission! Unfortunately, I can not give you any suggestions right away but if it's still needed, I could have a look in the list of reviewers.

@RMeli
Copy link

RMeli commented Sep 24, 2024

Thanks @mxwalbert. I'm already using the list of reviewers, as well as private channels. Since you are surely more familiar with the field, I was wondering if you had some suggestions outside of the list.

@enricgrau
Copy link

enricgrau commented Sep 25, 2024

@RMeli
Happy to help if still needed.

@RMeli
Copy link

RMeli commented Sep 26, 2024

@editorialbot add @enricgrau as reviewer

Thank you @enricgrau!

@editorialbot
Copy link
Collaborator Author

@enricgrau added to the reviewers list!

@RMeli
Copy link

RMeli commented Sep 26, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

6 participants