Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PySHbundle: A Python tool for processing GRACE Gravimetry data into Global Surface Mass Change Datasets #7279

Closed
editorialbot opened this issue Sep 25, 2024 · 35 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 25, 2024

Submitting author: @lsmvivek (Vivek Kumar Yadav)
Repository: https://github.com/GESS-research-group/pyshbundle
Branch with paper.md (empty if default branch):
Version: v0.3.0
Editor: @hugoledoux
Reviewers: @tsutterley, @MMesch
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913"><img src="https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913/status.svg)](https://joss.theoj.org/papers/d623f63c03c6b54f9b6f4fa633747913)

Author instructions

Thanks for submitting your paper to JOSS @lsmvivek. Currently, there isn't a JOSS editor assigned to your paper.

@lsmvivek if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Sep 25, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.26 s (178.1 files/s, 80566.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            987           1572           1780
Jupyter Notebook                 5              0          14443            710
Markdown                        17            273              0            581
YAML                             5             13             10            280
TeX                              1             14              0             77
TOML                             1              5              0             48
HTML                             1              2              0              9
XML                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                            46           1294          16025           3486
-------------------------------------------------------------------------------

Commit count by author:

   185	Abhishek Mhamane
   182	Amin Shakya
   158	lsmvivek
    44	mn5hk
    23	Vivek
     7	vivek
     3	Walling9
     1	Bramha Dutt Vishwakarma

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/s10712-022-09754-9 is OK
- 10.5281/zenodo.8075728 is OK
- 10.18419/opus-9193 is OK
- 10.1002/2017WR021150 is OK
- 10.1029/98JB02844 is OK
- 10.1029/2018GC007529 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ggtools 1.1.7
- No DOI given, and none found for title: SHBUNDLE 2021
- No DOI given, and none found for title: GitHub - Strawpants/GRACE-filter: Contains softwar...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1164

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis
Submitting author: @sebhaan
Handling editor: @hugoledoux (Active)
Reviewers: @lukasbeuster, @martibosch
Similarity score: 0.6892

Tide Model Driver for MATLAB
Submitting author: @chadagreene
Handling editor: @kthyng (Active)
Reviewers: @adamdanz, @lnferris
Similarity score: 0.6866

PyGDH: Python Grid Discretization Helper
Submitting author: @kfhiga
Handling editor: @melissawm (Retired)
Reviewers: @JamieJQuinn, @zhaowei0566
Similarity score: 0.6838

PySPOD: A Python package for Spectral Proper Orthogonal Decomposition (SPOD)
Submitting author: @mengaldo
Handling editor: @eloisabentivegna (Retired)
Reviewers: @albertonogueira, @joao-l-s-almeida, @jdmoorman
Similarity score: 0.6770

KerrGeoPy: A Python Package for Computing Timelike Geodesics in Kerr Spacetime
Submitting author: @syp2001
Handling editor: @xuanxu (Active)
Reviewers: @Uddiptaatwork, @sterinaldi
Similarity score: 0.6752

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng
Copy link

kthyng commented Sep 25, 2024

Hi @lsmvivek and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

I know this is a resubmission — please note here any important items from previous submission we should know (here is a link to the last one #7183).

@lsmvivek
Copy link

lsmvivek commented Sep 27, 2024

Hi @lsmvivek and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

I know this is a resubmission — please note here any important items from previous submission we should know (here is a link to the last one #7183).

Hello @kthyng,
Indeed this is a resubmission. I went through the reviewer database and I suggest the following 5 people based on their work profile. Please let me know if anything else is needed.

Geodesy:

  • busstoptaktik
  • leouieda
  • jiangyuinsar

Glaciers:

  • JordiBolibar
  • tgoelles

@kthyng
Copy link

kthyng commented Oct 2, 2024

@lsmvivek

@lsmvivek
Copy link

lsmvivek commented Oct 4, 2024

@lsmvivek

Please follow the updated link: https://gess-research-group.github.io/pyshbundle/

@lsmvivek
Copy link

Gentle reminder,
Please follow the updated link: https://gess-research-group.github.io/pyshbundle/
@kthyng

@kthyng
Copy link

kthyng commented Oct 22, 2024

@lsmvivek Ok great. Sorry I have been traveling plus had a deadline. Now I am back.
We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

@kthyng kthyng added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Oct 22, 2024
@kthyng
Copy link

kthyng commented Oct 22, 2024

@lsmvivek Did I already suggest giving a more descriptive title to this paper? It seems one already needs to know what this package does in order to know what the title means. I struggle with this whenever I try to search for an editor for the submission.

@lsmvivek
Copy link

@lsmvivek Did I already suggest giving a more descriptive title to this paper? It seems one already needs to know what this package does in order to know what the title means. I struggle with this whenever I try to search for an editor for the submission.

Dear @kthyng
I have updated the paper title.
It clearly states the objective of the software, data it works with and the expected output.
I have also added more keywords (Geodesy, Gravimetry, Terrestrial Water Storage).

I thank you for suggestion, please let me know if any other changes are needed.

@kthyng
Copy link

kthyng commented Oct 28, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Geodata-Harvester: A Python package to jumpstart geospatial data extraction and analysis
Submitting author: @sebhaan
Handling editor: @hugoledoux (Active)
Reviewers: @lukasbeuster, @martibosch
Similarity score: 0.7021

Integrated hydrologic model development and postprocessing for GSFLOW using pyGSFLOW
Submitting author: @jlarsen-usgs
Handling editor: @crvernon (Active)
Reviewers: @thurber, @mdbartos, @mdbartos
Similarity score: 0.6950

baseflow: a MATLAB and GNU Octave package for baseflow recession analysis
Submitting author: @mgcooper
Handling editor: @elbeejay (Active)
Reviewers: @alessandroamaranto, @tianydong
Similarity score: 0.6921

HyRiver: Hydroclimate Data Retriever
Submitting author: @cheginit
Handling editor: @kthyng (Active)
Reviewers: @raoulcollenteur, @arbennett
Similarity score: 0.6910

Tide Model Driver for MATLAB
Submitting author: @chadagreene
Handling editor: @kthyng (Active)
Reviewers: @adamdanz, @lnferris
Similarity score: 0.6883

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@kthyng kthyng changed the title [PRE REVIEW]: PySHbundle: A Python software to convert GRACE Spherical Harmonic Coefficients to gridded mass change fields [PRE REVIEW]: PySHbundle: A Python tool for processing GRACE Gravimetry data into Global Surface Mass Change Datasets Oct 28, 2024
@kthyng
Copy link

kthyng commented Oct 28, 2024

@hugoledoux Can you edit this submission?

@kthyng
Copy link

kthyng commented Oct 28, 2024

@editorialbot invite @hugoledoux as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@hugoledoux
Copy link

@editorialbot assign @hugoledoux as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @hugoledoux is now the editor

@danielskatz danielskatz removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Oct 31, 2024
@hugoledoux
Copy link

@MMesch would you be willing to review this submission? (I couldn't find an email and I tried hard; a few people said you'd be a great reviewer for this)

@MMesch
Copy link

MMesch commented Nov 27, 2024

@hugoledoux Yes I would be willing to do this depending on exact criteria and timeline. I wrote you a DM on Mastodon for further contact details.

@hugoledoux
Copy link

@editorialbot assign @tsutterley as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@hugoledoux
Copy link

@editorialbot add @tsutterley as reviewer

@editorialbot
Copy link
Collaborator Author

@tsutterley added to the reviewers list!

@hugoledoux
Copy link

@hugoledoux Yes I would be willing to do this depending on exact criteria and timeline. I wrote you a DM on Mastodon for further contact details.

@MMesch I sent you an email last week, have you received it?

@hugoledoux
Copy link

@editorialbot add @MMesch as reviewer

@editorialbot
Copy link
Collaborator Author

@MMesch added to the reviewers list!

@hugoledoux
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7550.

@hugoledoux
Copy link

sorry for the delay @lsmvivek, we now have 2 very suitable reviewers and it's started at #7550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants