-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: KerrGeoPy: A Python Package for Computing Timelike Geodesics in Kerr Spacetime #6587
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
👋 Hi @Uddiptaatwork and @sterinaldi, and thank you for agreeing to review this submission for KerrGeoPy ! The review will take place in this issue, and you can generate your individual reviewer checklists by asking editorialbot directly with The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #6587 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. As you go over the submission, please check any items on your reviewer checklist that you feel have been satisfied. If you aren't sure how to get started, please see the JOSS reviewer guidelines -- and of course, feel free to ping me (@xuanxu) with any questions ! We aim for reviews to be completed within four weeks, or six weeks at latest. Please let me know if either of you require some more time. We can also use editorialbot (our bot) to set automatic reminders if you know you'll be away for a known period of time. If you any questions or concerns arise, please feel free to ask here or via email. And thank you again ! |
Thanks @xuanxu! I'll start the review in the next few days. |
Review checklist for @sterinaldiConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 @Uddiptaatwork, @sterinaldi Can you update us on the progress of your review? |
@Uddiptaatwork I've noticed you have not created your review checklist yet, please do so by running this command in a separate comment:
|
Hi @xuanxu, sorry for the late reply, I had a few hectic days. So far, I managed to install the code on a fresh environment, run the automated tests and played a bit with the code, which seems to work well so far. I think I'll be able to have a more thorough look at the documentation and the paper by the end of next week. |
Review checklist for @UddiptaatworkConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @syp2001, I was looking for some indications about how to contribute to the code but I couldn't find any – could you please tell me whether if this is specified somewhere or it's still to be added? |
Hi @xuanxu, I completed the checklist. Caveat the contribution point (see comment above), I'm happy with the package and the paper and, as soon as that point is addressed, this submission has green light from my side. |
Hi @sterinaldi, sorry for the late reply. There are currently no community guidelines specified, but I am working on writing them and they should hopefully be up within the next few days. |
Thanks! I found this template pretty useful, myself: https://github.com/nayafia/contributing-template |
@Uddiptaatwork any update on how your review is going? |
Hi @sterinaldi, sorry again for the delay. I finally had time to write the guidelines and they are up at https://github.com/BlackHolePerturbationToolkit/KerrGeoPy/blob/main/CONTRIBUTING.md now. |
Thanks @sterinaldi! can you confirm you recommend the submission for publication? |
Yes, I confirm that I recommend this paper for publication. |
Apologies for the delay, we were going through a few closures at our institute due to extraneous (geopolitical) reasons. I just finished going through the paper, documentation and currently running tests for a final sanity check. I will get back to you in an hour with the sanity checks. |
|
Looking good! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5414, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5428, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Many thanks to @Uddiptaatwork and @sterinaldi for reviewing and to @xuanxu for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @syp2001 — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@editorialbot generate preprint |
📄 Preprint file created: Find it here in the Artifacts list 📄 |
Submitting author: @syp2001 (Seyong Park)
Repository: https://github.com/BlackHolePerturbationToolkit/KerrGeoPy
Branch with paper.md (empty if default branch): paper
Version: v0.9.3
Editor: @xuanxu
Reviewers: @Uddiptaatwork, @sterinaldi
Archive: 10.5281/zenodo.11386563
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Uddiptaatwork & @sterinaldi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @xuanxu know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @sterinaldi
📝 Checklist for @Uddiptaatwork
The text was updated successfully, but these errors were encountered: