Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Gauss-Radau Small-body Simulator (GRSS): An Open-Source Library for Planetary Defense #7488

Open
editorialbot opened this issue Nov 15, 2024 · 23 comments
Labels
AAS Papers being published together with a AAS submission pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 15, 2024

Submitting author: @rahil-makadia (Rahil Makadia)
Repository: https://github.com/rahil-makadia/grss
Branch with paper.md (empty if default branch): dev
Version: v4.3.6
Editor: Pending
Reviewers: Pending
Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a9e005a6db1bdc3bbfd50301f4ce8f52"><img src="https://joss.theoj.org/papers/a9e005a6db1bdc3bbfd50301f4ce8f52/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a9e005a6db1bdc3bbfd50301f4ce8f52/status.svg)](https://joss.theoj.org/papers/a9e005a6db1bdc3bbfd50301f4ce8f52)

Author instructions

Thanks for submitting your paper to JOSS @rahil-makadia. Currently, there isn't a JOSS editor assigned to your paper.

@rahil-makadia if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Nov 15, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.09 s (1192.4 files/s, 242553.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             18            426           1420           8196
Python                          17            384           1893           3888
C/C++ Header                    14            178            806            763
Jupyter Notebook                 8              0           1445            362
YAML                             7              6              1            223
TeX                              1             11              0            137
Markdown                         2             44              0            109
SVG                              3              0              1            109
reStructuredText                22             99            218            104
TOML                             1              8              0             73
Bourne Shell                     6             13             12             69
CMake                            3             13             21             69
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           104           1194           5825          14137
-------------------------------------------------------------------------------

Commit count by author:

   582	Rahil Makadia

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.3847/PSJ/ac7de7 is OK
- 10.3847/PSJ/ad1bce is OK
- 10.1093/mnras/stu2164 is OK
- 10.1016/0032-0633(61)90293-8 is OK
- 10.1006/icar.1999.6135 is OK
- 10.1007/s10569-019-9914-4 is OK
- 10.3847/1538-3881/abd414 is OK
- 10.3847/PSJ/acc9a9 is OK
- 10.3847/1538-4365/acc173 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Gauss-Radau Small-body Simulator (GRSS): An Open-S...
- No DOI given, and none found for title: Orbit Determination and Estimation of Impact Proba...

❌ MISSING DOIs

- 10.1016/0019-1035(78)90014-3 may be a valid DOI for title: Interplanetary Encounters: Close-range Gravitation...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 763

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@warrickball
Copy link

@rahil-makadia — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@warrickball warrickball added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 15, 2024
@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

KerrGeoPy: A Python Package for Computing Timelike Geodesics in Kerr Spacetime
Submitting author: @syp2001
Handling editor: @xuanxu (Active)
Reviewers: @Uddiptaatwork, @sterinaldi
Similarity score: 0.7081

SpiceyPy: a Pythonic Wrapper for the SPICE Toolkit
Submitting author: @andrewannex
Handling editor: @mbobra (Active)
Reviewers: @hayesla, @jessie-dotson
Similarity score: 0.7076

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.6955

NAIF PDS4 Bundler: A Python package to generate SPICE PDS4 archives
Submitting author: @mcostasitja
Handling editor: @mbobra (Active)
Reviewers: @athulpg007, @SimonMolinsky
Similarity score: 0.6813

GECo: A collection of solvers for the self-gravitating Vlasov equations
Submitting author: @anderslogg
Handling editor: @dfm (Active)
Reviewers: @michellegurevich, @pmocz
Similarity score: 0.6807

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@warrickball warrickball added the AAS Papers being published together with a AAS submission label Nov 15, 2024
@warrickball
Copy link

For whichever editor might pick this up, note that this is a joint publication with AAS Journals (specifically, the Planetary Science Journal). 🌍

@rahil-makadia
Copy link

@warrickball Looks like it might take some time before the review starts on this paper. Let me know if there's anything to do in the meantime or if it's just a waiting game right now...

@warrickball
Copy link

I'm afraid it is mostly a waiting game. Hopefully an editor will become available within a week or two, and they'll then start seeking reviewers.

The basic metadata properties all look good. My only comment on the paper at this point is that we prefer inline hyperlinks to footnotes.

@rahil-makadia
Copy link

@editorialbot set dev as branch

Changing branch to dev since that's where I first make edits

@editorialbot
Copy link
Collaborator Author

Done! branch is now dev

@rahil-makadia
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.09 s (1162.0 files/s, 236552.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             18            426           1421           8202
Python                          17            384           1893           3891
C/C++ Header                    14            178            806            763
Jupyter Notebook                 8              0           1445            362
YAML                             7              6              1            223
TeX                              1             11              0            137
Markdown                         2             44              0            109
SVG                              3              0              1            109
reStructuredText                22             99            218            105
TOML                             1              8              0             73
CMake                            3             13             22             72
Bourne Shell                     6             13             12             69
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           104           1194           5827          14150
-------------------------------------------------------------------------------

Commit count by author:

   589	Rahil Makadia

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 802

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@rahil-makadia
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

KerrGeoPy: A Python Package for Computing Timelike Geodesics in Kerr Spacetime
Submitting author: @syp2001
Handling editor: @xuanxu (Active)
Reviewers: @Uddiptaatwork, @sterinaldi
Similarity score: 0.6805

GECo: A collection of solvers for the self-gravitating Vlasov equations
Submitting author: @anderslogg
Handling editor: @dfm (Active)
Reviewers: @michellegurevich, @pmocz
Similarity score: 0.6673

SpiceyPy: a Pythonic Wrapper for the SPICE Toolkit
Submitting author: @andrewannex
Handling editor: @mbobra (Active)
Reviewers: @hayesla, @jessie-dotson
Similarity score: 0.6655

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.6648

MG-MAMPOSSt, a Fortran code to test gravity at galaxy-cluster scales
Submitting author: @Pizzuti92
Handling editor: @eloisabentivegna (Retired)
Reviewers: @ttricco, @eloisabentivegna
Similarity score: 0.6584

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@rahil-makadia
Copy link

@editorialbot generate pdf

I have updated the footnotes to inline hyperlinks as per suggestion

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

SpiceyPy: a Pythonic Wrapper for the SPICE Toolkit
Submitting author: @andrewannex
Handling editor: @mbobra (Active)
Reviewers: @hayesla, @jessie-dotson
Similarity score: 0.7169

KerrGeoPy: A Python Package for Computing Timelike Geodesics in Kerr Spacetime
Submitting author: @syp2001
Handling editor: @xuanxu (Active)
Reviewers: @Uddiptaatwork, @sterinaldi
Similarity score: 0.7127

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.6976

NAIF PDS4 Bundler: A Python package to generate SPICE PDS4 archives
Submitting author: @mcostasitja
Handling editor: @mbobra (Active)
Reviewers: @athulpg007, @SimonMolinsky
Similarity score: 0.6953

Swiftest: An \textit{N}-body Integrator for Gravitational Systems
Submitting author: @carlislewishard
Handling editor: @warrickball (Active)
Reviewers: @hannorein, @mikegrudic, @aatrani
Similarity score: 0.6924

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AAS Papers being published together with a AAS submission pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

3 participants