-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ESAT: Environmental Source Apportionment Toolkit Python package #7316
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@editorialbot generate pdf |
👋🏼 @deronsmith, @gutabeshu, @ifoxfoot, @niravlekinwala - This is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me ( |
Review checklist for @ifoxfootConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
@openjournals/dev - The PDF is not generating correctly. Could you please help me looking into the issue? Thank you! @gutabeshu, @ifoxfoot, @niravlekinwala @deronsmith - In the meantime, you can access the most recent PDF from the Pre-Review stage here: #7215 (comment). Apologies for the inconvenience! |
@editorialbot generate pdf |
@mengqi-z – the issue here is that there are two |
@arfon - Ah, I see! It turns out there is a |
Thank you for your patience while this issue was resolved. The paper.md file in docs has been removed and the corresponding directories added to gitignore to prevent future issues. |
@editorialbot generate pdf |
@editorialbot generate pdf |
Review checklist for @niravlekinwalaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi, Are there any updates on this review? |
@mengqi-z Yes, the |
@editorialbot set v2024.0.3-alpha as version |
Done! version is now v2024.0.3-alpha |
@editorialbot set 10.23719/1531870 as archive |
Done! archive is now 10.23719/1531870 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6208, then you can now move forward with accepting the submission by compiling again with the command |
@deronsmith – I’ve recommended your submission for acceptance. Thanks so much for submitting to JOSS! From here, our Editor-in-Chief will step in to do some final checks before the paper can be officially accepted and published. Congrats and great job! @gutabeshu, @ifoxfoot, @niravlekinwala – Huge thanks to all of you for reviewing this paper! It’s been great working with you during this process, and I really appreciate your thoughtful feedback. I look forward to seeing your reviews for JOSS in the future! |
@mengqi-z Thank you for coordinating everything, and thank you reviewers for all your work. Much appreciated! |
Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!
|
Please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file. For example "china" and "south korea" are not capitalized but please check for others. |
@editorialbot generate pdf |
Ok everything looks ready to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on your new publication @deronsmith! Many thanks to editor @mengqi-z and to reviewers @gutabeshu, @ifoxfoot, and @niravlekinwala for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Note we have a new tool for reviewers! You can go to https://joss.theoj.org/papers/reviewed_by/@your-github-username to see the JOSS submissions you have reviewed, and you can also copy a badge there with the number of your JOSS reviews. @deronsmith If you'd like to join JOSS as a reviewer, please sign up at https://reviewers.joss.theoj.org/join! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @deronsmith (Deron Smith)
Repository: https://github.com/quanted/esat
Branch with paper.md (empty if default branch):
Version: v2024.0.3-alpha
Editor: @mengqi-z
Reviewers: @gutabeshu, @ifoxfoot, @niravlekinwala
Archive: 10.23719/1531870
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gutabeshu & @ifoxfoot & @niravlekinwala, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mengqi-z know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @ifoxfoot
📝 Checklist for @niravlekinwala
📝 Checklist for @gutabeshu
The text was updated successfully, but these errors were encountered: