Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post-graduation checklist #386

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Add post-graduation checklist #386

merged 2 commits into from
Apr 14, 2020

Conversation

tobie
Copy link
Contributor

@tobie tobie commented Oct 31, 2019

  • Include formal IP transfers and related tooling, which cannot happen
    before project has formally graduated from incubation
  • Modify onboarding checklist so that IP related tasks are limited to
    listing related assets and committing to post-graduation transfer.
  • Use the term trademark instead of logomark.
  • Update related issue template
  • Create additional issue template for post-graduation checklist.

Closes #378, closes #380.

@tobie
Copy link
Contributor Author

tobie commented Oct 31, 2019

Happy to submit this more formally as a proposal if necessary. I just wanted to document this as I was moving through the incubation process with the AMP project and figured a PR was the easiest and most actionable way to do so.

mhdawson
mhdawson approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Nov 1, 2019

Based on past process we'll need board approval to land (there is also discussion about relaxing this but it has not concluded yet).

@mhdawson
Copy link
Member

mhdawson commented Nov 1, 2019

@tobie thanks for the update.

@tobie tobie mentioned this pull request Nov 3, 2019
Closed
1 task
@tobie tobie mentioned this pull request Nov 6, 2019
Closed
2 tasks
@mhdawson
Copy link
Member

mhdawson commented Dec 2, 2019

@tobie looks like next step is for you to address some comments and then I'll take it to the board for approval.

@mhdawson
Copy link
Member

mhdawson commented Dec 2, 2019

Thinking further I think this also needs more approvals from the @openjs-foundation/cpc based on :

Pull requests that change the charter of the CPC must meet the following conditions in addition to the ones listed for changing CPC governance:

  • The text of the PR must be approved by a simple majority of the voting members.
  • The text of the PR must be approved by the board.

brianwarner
brianwarner reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@brianwarner brianwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a line about SPDX short-form identifiers, as an example of information that should be in various files. This example is given in the IP Policy

Signed-off-by: Brian Warner brian@bdwarner.com

@mhdawson mhdawson mentioned this pull request Dec 9, 2019
Closed
@tobie tobie mentioned this pull request Dec 10, 2019
Closed
@mhdawson mhdawson mentioned this pull request Dec 16, 2019
Closed
@MylesBorins
Copy link
Contributor

The other issue template for onboarding got moved to another repo. Should this move there too?

@mhdawson mhdawson mentioned this pull request Jan 6, 2020
Closed
@tobie
Copy link
Contributor Author

tobie commented Jan 7, 2020 •
edited
Loading

The other issue template for onboarding got moved to another repo. Should this move there too?

Do we want to approve it here first or should I move this right away?

@ljharb ljharb mentioned this pull request Jan 7, 2020
Open
@mhdawson
Copy link
Member

mhdawson commented Jan 7, 2020

@tobie I'm good either way, the template don't need Board approval so if we keep them in this PR and get approval then we can move them easily afterwards.

@tobie
Copy link
Contributor Author

tobie commented Jan 7, 2020

@mhdawson easier for me to merge this first and then move. SSD died. I'm currently using a Chromebook so pretty much limited to GH's web interface.

@mhdawson mhdawson mentioned this pull request Jan 13, 2020
Closed
joesepi
joesepi approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me; however it makes sense to merge and/or move.

@mhdawson mhdawson mentioned this pull request Jan 20, 2020
Closed
@mhdawson
Copy link
Member

@openjs-foundation/cpc, @tobie if we can agree and get this ready to land we could possibly get a vote on it by the board this week.

@mhdawson mhdawson mentioned this pull request Feb 10, 2020
Closed
@mhdawson mhdawson mentioned this pull request Feb 17, 2020
Closed
@mhdawson mhdawson mentioned this pull request Feb 24, 2020
Closed
@joesepi
Copy link
Member

joesepi commented Feb 25, 2020

9 out of 15 voting members have approved this PR. We should resolve conflicts, merge and then move any documentation that has moved to new repos.

codeekage
codeekage approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@codeekage codeekage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make that 10 of 15

This was referenced Mar 2, 2020
Closed
Closed
@mhdawson mhdawson mentioned this pull request Mar 16, 2020
Closed
@mhdawson mhdawson mentioned this pull request Mar 23, 2020
Closed
@tobie @maddhruv
Add post-graduation checklist
bb59d8a 
* Include formal IP transfers and related tooling, which cannot happen
  before project has formally graduated from incubation
* Modify onboarding checklist so that IP related tasks are limited to
  listing related assets and committing to post-graduation transfer.
* Use the term trademark instead of logomark.
* Update URLs in comments to point to new location of issue templates.

Closes openjs-foundation#378, closes openjs-foundation#380.

Co-Authored-By: Dhruv Jain <dhruvjainpenny@gmail.com>
@tobie tobie force-pushed the post-graduation-checklist branch from d69d274 to bb59d8a Compare March 24, 2020 14:18
tobie added a commit to tobie/project-onboarding that referenced this pull request Mar 24, 2020
@tobie
Update issue templates with post-graduation checklist
624fce6 
Depends on openjs-foundation/cross-project-council#386.
@tobie tobie mentioned this pull request Mar 24, 2020
Merged
@tobie
Copy link
Contributor Author

tobie commented Mar 24, 2020

Updated this issue so that it can now be merged.

Added openjs-foundation/project-status#42 sot that the additional issue template and changes to the pre-existing template are added to the project-onboarding repository.

@mhdawson
Copy link
Member

@tobie thanks. I'll send an email to @brianwarner asking for a Board vote on this which we believe is required for this one.

tobie
tobie commented Mar 24, 2020
View reviewed changes
@mhdawson mhdawson mentioned this pull request Mar 30, 2020
Closed
This was referenced Apr 6, 2020
Closed
Closed
@keywordnew keywordnew mentioned this pull request Apr 13, 2020
Closed
@mhdawson
Copy link
Member

@brianwarner confirmed board vote is complete, landing

@mhdawson mhdawson merged commit 89a9a17 into openjs-foundation:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@maddhruv maddhruv maddhruv left review comments

@brianwarner brianwarner brianwarner left review comments

@mikesamuel mikesamuel mikesamuel approved these changes

@eemeli eemeli eemeli approved these changes

@dmethvin dmethvin dmethvin approved these changes

@timmywil timmywil timmywil approved these changes

@kborchers kborchers kborchers approved these changes

@dylans dylans dylans approved these changes

@molant molant molant approved these changes

@joesepi joesepi joesepi approved these changes

@christian-bromann christian-bromann christian-bromann approved these changes

@boneskull boneskull boneskull approved these changes

@mcollina mcollina mcollina approved these changes

@WaleedAshraf WaleedAshraf WaleedAshraf approved these changes

@mhdawson mhdawson mhdawson approved these changes

@knolleary knolleary knolleary approved these changes

@codeekage codeekage codeekage approved these changes

@dpgraham dpgraham Awaiting requested review from dpgraham

@Jonahss Jonahss Awaiting requested review from Jonahss

@TheLarkInn TheLarkInn Awaiting requested review from TheLarkInn

Assignees
No one assigned
Labels
board approval required
Projects
None yet
Milestone
No milestone