Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to CoC Handling #407

Merged
merged 5 commits into from
Nov 27, 2019
Merged

Changes to CoC Handling #407

merged 5 commits into from
Nov 27, 2019

Conversation

nainar
Copy link
Contributor

@nainar nainar commented Nov 14, 2019

Changes made:

  • s/reportee/reporter or target
  • Add a link to CoC

Changes made: 
- s/reportee/reporter or target
- Add a link to CoC
Co-Authored-By: Antón Molleda <molant@users.noreply.github.com>
@ljharb
Copy link
Member

ljharb commented Nov 15, 2019

It'd be ideal to use 1. for all numbered list items; then we never have to keep track of the numbering.

@nainar
Copy link
Contributor Author

nainar commented Nov 16, 2019

Changed the numbering to be all 1.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@eemeli are you still objecting to this landing. Your comment is resolved but you still have a blocking review open.

@mhdawson
Copy link
Member

Pushed commit to address last comment. We agreed it could land with that being updated.

@mhdawson mhdawson merged commit d688321 into openjs-foundation:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants