Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix hot reloading for docker and bare metal #1057

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

daniel-arnauer
Copy link
Contributor

Hot reloading is broken in react-scripts, more information: facebook/create-react-app#11879

This PR fixes the hot reloading with an additional script.

@github-actions
Copy link

github-actions bot commented Mar 24, 2022

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against ca01236

@daniel-arnauer daniel-arnauer force-pushed the fix-frontent-hot-reloading branch 2 times, most recently from 876d77b to d1e04ad Compare March 24, 2022 11:05
@openkfwCI
Copy link

openkfwCI commented Mar 24, 2022

NotesTime
Note for Reviewer: E2E tests on remote server succeededWed, 30 Mar 2022 08:02:58 +0000

Generated by E2E-Test

@daniel-arnauer daniel-arnauer self-assigned this Mar 24, 2022
@daniel-arnauer daniel-arnauer force-pushed the fix-frontent-hot-reloading branch 2 times, most recently from c780be8 to 7d7ef59 Compare March 28, 2022 11:14
@daniel-arnauer daniel-arnauer removed their assignment Mar 28, 2022
Daniel Arnauer added 3 commits March 30, 2022 09:14
Hot reloading is broken in react-scripts, more
information: facebook/create-react-app#11879
Resolve eslint rule @typescript-eslint/return-await
If there is no try-catch block, an async function can return the
Promise directly instead of awaiting it.

See https://stackoverflow.com/questions/38708550/difference-between-return-await-promise-and-return-promise
for further explanation.
@daniel-arnauer daniel-arnauer merged commit b180002 into master Mar 30, 2022
@daniel-arnauer daniel-arnauer deleted the fix-frontent-hot-reloading branch May 10, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants